Add hover on i18n translations #640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domingo2000
commented
Jul 27, 2025
| when "reload_i18n" | ||
| with_progress("rails-reload-i18n", "Reloading Ruby LSP Rails I18n") do | ||
| with_notification_error_handling(request) do | ||
| I18n.reload! if defined?(I18n) && I18n.respond_to?(:reload!) |
There was a problem hiding this comment.
This is provided because other I18n backend maybe does not implement the reloading feature.
brunoprietog
reviewed
Aug 4, 2025
| RunnerClient.any_instance.stubs(i18n: expected_response) | ||
|
|
||
| response = hover_on_source(<<~RUBY, { line: 0, character: 9 }) | ||
| I18n.t("foo") |
There was a problem hiding this comment.
This could also be just t if we consider that you could be inside Action View, but perhaps that is beyond the scope.
There was a problem hiding this comment.
Yes, its out of scope. This changes only support I18n.t("some-key") calls. With absolute key and string literal as argument.
To support t notation for ActionView, we need the context of which file is beign parsed and be able to complete the call of I18n in an ActionView context, or with the scope of that specific file. It could be a nice follow up if you want to help 👍🏻 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation for I18n support (#639)
How it works
I18n.t("hello")key string argument, request the server all the translations available and provide hover info for that.It address points 1 and 2 of the issue list:
And is usefull for updating and creating translations because it gives feedback that the used translations "is correct" because makes direct calls to the I18n backend while typing and hovering it. Warning if the translation is missing.
This gives the following experience:
Screencast from 2025-07-27 00-40-33.webm