Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON test reporter for minitest #3187

Merged
merged 10 commits into from
Mar 6, 2025
Merged

Add JSON test reporter for minitest #3187

merged 10 commits into from
Mar 6, 2025
+247 −11

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Feb 12, 2025 •
edited
Loading

Addresses #3176

This adds a custom reporter for use with the upcoming changes planned for the Test Explorer UI. It emits the test progress as a series of events, for easy consumption by the VS Code extension.

To test the runner output locally:

RUBYOPT="-r./lib/ruby_lsp/ruby_lsp_reporter_plugin.rb" bundle exec ruby -Itest test/fixtures/minitest_example.rb

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 12, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from 9e0d218 to 93c2d6d Compare February 12, 2025 14:57
@andyw8 andyw8 changed the title Prototyping for custom test reporter Prototyping for custom test reporters Feb 12, 2025
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch 2 times, most recently from 58ddebf to c31bee6 Compare February 14, 2025 18:32
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch 3 times, most recently from 94fb924 to b8fd1ab Compare February 14, 2025 18:52
@andyw8 andyw8 changed the title Prototyping for custom test reporters Add prototype for custom test reporter for minitest Feb 14, 2025
@andyw8 andyw8 marked this pull request as ready for review February 14, 2025 18:54
@andyw8 andyw8 requested a review from a team as a code owner February 14, 2025 18:54
@andyw8 andyw8 added chore Chore task enhancement New feature or request server This pull request should be included in the server gem's release notes and removed chore Chore task labels Feb 14, 2025
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from b8fd1ab to 30a66c9 Compare February 14, 2025 19:27
vinistock
vinistock reviewed Feb 14, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from a82f421 to c71eb8b Compare February 18, 2025 16:01
st0012
st0012 reviewed Feb 18, 2025
View reviewed changes
andyw8
andyw8 commented Feb 24, 2025
View reviewed changes
@andyw8 andyw8 mentioned this pull request Feb 24, 2025
Closed
vinistock
vinistock requested changes Feb 24, 2025
View reviewed changes
andyw8
andyw8 commented Feb 24, 2025
View reviewed changes
@andyw8 andyw8 marked this pull request as draft February 24, 2025 19:38
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch 2 times, most recently from c6cab8d to 519d241 Compare February 25, 2025 15:23
@andyw8 andyw8 changed the title Add prototype for custom test reporter for minitest WIP: Add prototype for custom test reporter for minitest Mar 4, 2025
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from e7a8688 to cac1556 Compare March 5, 2025 15:27
@andyw8 andyw8 changed the title WIP: Add prototype for custom test reporter for minitest WIP: Add custom test reporter for minitest Mar 5, 2025
@andyw8 andyw8 changed the title WIP: Add custom test reporter for minitest WIP: Add JSON test reporter for minitest Mar 5, 2025
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch 2 times, most recently from fb130b9 to 6134817 Compare March 5, 2025 17:46
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from 6134817 to 3295ec2 Compare March 5, 2025 17:58
@andyw8 andyw8 changed the title WIP: Add JSON test reporter for minitest Add JSON test reporter for minitest Mar 5, 2025
@andyw8 andyw8 requested a review from alexcrocha March 5, 2025 17:58
@andyw8 andyw8 marked this pull request as ready for review March 5, 2025 17:58
andyw8
andyw8 commented Mar 5, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from 3295ec2 to 6887898 Compare March 5, 2025 17:59
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from 42b5a3a to 057da0b Compare March 5, 2025 19:45
vinistock
vinistock reviewed Mar 6, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/custom-test-reporter branch from bf87ed1 to 8df3025 Compare March 6, 2025 15:13
vinistock
vinistock approved these changes Mar 6, 2025
View reviewed changes
@andyw8 andyw8 enabled auto-merge (squash) March 6, 2025 17:10
@andyw8 andyw8 merged commit a205912 into main Mar 6, 2025
42 checks passed
@andyw8 andyw8 deleted the andyw8/custom-test-reporter branch March 6, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 left review comments

@vinistock vinistock vinistock approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha

Assignees
No one assigned
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyw8 @st0012 @vinistock