Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test-unit reporter #3238

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Add test-unit reporter #3238

merged 1 commit into from
Feb 28, 2025

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Feb 25, 2025 •
edited
Loading

Addresses part of #3176

Note: The omission feature in test-unit is not currently supported.

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 25, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch 3 times, most recently from bbcd594 to fe0057a Compare February 25, 2025 20:55
@andyw8 andyw8 added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Feb 25, 2025
vinistock
vinistock reviewed Feb 25, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch 2 times, most recently from 962428f to 8e613f5 Compare February 26, 2025 21:26
andyw8
andyw8 commented Feb 26, 2025
View reviewed changes
@andyw8 andyw8 changed the title WIP: Add test-unit reporter Add test-unit reporter Feb 26, 2025
@andyw8 andyw8 marked this pull request as ready for review February 26, 2025 21:31
@andyw8 andyw8 requested a review from a team as a code owner February 26, 2025 21:31
@andyw8 andyw8 requested a review from alexcrocha February 26, 2025 21:31
@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch from 8e613f5 to 12dd221 Compare February 26, 2025 21:32
@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch 2 times, most recently from bab08ac to 0343c22 Compare February 26, 2025 22:04
andyw8
andyw8 commented Feb 27, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch 2 times, most recently from 4727df3 to b2f2082 Compare February 27, 2025 17:29
vinistock
vinistock reviewed Feb 27, 2025
View reviewed changes
vinistock
vinistock reviewed Feb 27, 2025
View reviewed changes
vinistock
vinistock reviewed Feb 27, 2025
View reviewed changes
@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch 2 times, most recently from bbf494c to 54b2c6d Compare February 28, 2025 13:40
vinistock
vinistock reviewed Feb 28, 2025
View reviewed changes
vinistock
vinistock approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can make the reporter typed strict though

@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch from 5a8d752 to 1daed81 Compare February 28, 2025 18:44
@andyw8 andyw8 added the graphite-merge Ship this PR using Graphite's merge queue label Feb 28, 2025
@andyw8 Graphite App
Copy link
Contributor Author

andyw8 commented Feb 28, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 28, 1:44 PM EST: The merge label 'graphite-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 28, 1:44 PM EST: The merge label 'graphite-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 28, 1:46 PM EST: The merge label 'graphite-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 28, 4:35 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 28, 5:01 PM EST: A user merged this pull request with the Graphite merge queue.

@andyw8 andyw8 force-pushed the andyw8/test-unit-reporter branch from 1daed81 to a8b9f6d Compare February 28, 2025 21:08
@andyw8
Add test-unit reporter (#3238)
08ec2e7 
Addresses part of #3176

Note: The `omission` feature in test-unit is not currently supported.
@graphite-app graphite-app bot force-pushed the andyw8/test-unit-reporter branch from a8b9f6d to 08ec2e7 Compare February 28, 2025 21:35
@graphite-app graphite-app bot merged commit 08ec2e7 into main Feb 28, 2025
45 checks passed
@graphite-app graphite-app bot deleted the andyw8/test-unit-reporter branch February 28, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha

Assignees
No one assigned
Labels
enhancement New feature or request graphite-merge Ship this PR using Graphite's merge queue server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock