Add adaptive circuit breaker #760
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris-gaudel
reviewed
Sep 23, 2025
| attr_reader :name, :pid_controller, :ping_thread | ||
|
|
||
| def initialize(name:, kp: 1.0, ki: 0.1, kd: 0.0, | ||
| window_size: 10, history_duration: 3600, |
Contributor
There was a problem hiding this comment.
Regarding the calculation of online mean, Welford's algorithm was discussed as a solution to use constant space
Contributor
There was a problem hiding this comment.
Also, do we want to allow developers to configure the interval of integration? (history_duration)?
AbdulRahmanAlHamali
force-pushed
the
pid-take-2
branch
from
4c9eb68 to
550a46f
Compare
Aguasvivas22
force-pushed
the
pid-take-2
branch
from
69ab5b7 to
550a46f
Compare
Update variable names Fill sliding window with 1 hr worth data Add comment Update experiemnt resource to be deterministic Change deterministic default value to false Cleanup Remove unused variable Make initial seed error rate more customizable Add seed_error_rate as a property
* Prefilling added * Change initial duration to 900 s
* testing different circuit breaking scenarios * adding concurrency * adds more puts to get further information during phases * Fixing concurrency, unprotected ping, extras * update classic sustained test * cleaning up outdated tests, and testing without ping rate * modify ki instead of dividing by window size --------- Co-authored-by: Abdulrahman Alhamali <[email protected]>
AbdulRahmanAlHamali
force-pushed
the
pid-take-2
branch
from
d52fa4d to
56ed006
Compare
notify on state transitions and on controller updates
add vertical reference lines on classic CB state changes and more helper flex
Remove dependency injection
Fix integral windup
…reads Different Semians between different threads
* Set up automated test for PID controller Reset Update experiment graphs Delete existing image Done Update experiment graphs Update experiment graphs Refactor experiments folder and CI Update scope of commit Update experiment graphs Update experiment graphs Update Gemfile Update experiment graphs Move windup file into test folder Update experiment graphs CI should only commit main graphs Update experiment graphs New bot Fail fast Test Delete comment Update experiment graphs test Revert test Add the commit Test Test * Rework CI check Done Final
* allow max threads, and introduce slow query experiment * fix my experiment, and run all other experiments
* add tables, and fix bug in helper * remove useless check * replace with csv tables for better display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this implementation is currently 100% vibe-coded, the plan is to close this PR and create a new, clean one