This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Drop node 14 support and remove code deprecations #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonwittwer
approved these changes
Oct 11, 2023
paulomarg
force-pushed
the
drop_node_14_support
branch
2 times, most recently
from
cf19813
to
7883ccb
Compare
paulomarg
force-pushed
the
drop_node_14_support
branch
from
7883ccb
to
142222e
Compare
|
With Node 16 as the new minimum supported version, I wonder if it may be possible to change the I think this would resolve the issue I tried to raise in #657 a while back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Some of the dependencies we use in this repo no longer work at all on Node 14, so we must drop support for it in order to keep our dependencies up to date.
WHAT is this pull request doing?
Removing support for Node 14, and dropping CI checks using it.
Because this change is inherently a major release, we're also making previous deprecations final so we can go to v8.
It's easier to review this if we ignore the removal of the auto-generated files: https://github.com/Shopify/shopify-api-js/pull/1007/files/737838dde6c06b84e250e264b46c4a983cde9d61
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)