Begin process to replace Loom with Turbo

[paulomarg]

WHY are these changes introduced?

We want to revamp our build process for the packages in this repo for a few reasons:

• Building both ESM and CJS outputs to make it easier for more apps to import the package
• Building with a target fitting for Node 16 (which we still technically support) to make stack traces clearer
• Building with turbo + rollup instead of loom (which uses rollup internally) to make it easier for folks to contribute

These changes should have no effect on the final packages, other than the ones stated above.

[lizkenyon]

Suggested change

	banner: `/*! ${packageName}@${pkg.version} -- Copyright (c) 2023-present, Shopify Inc. -- license (MIT): https://github.com/Shopify/shopify-app-js/blob/main/LICENSE.md */`,
	banner: `/*! ${packageName}@${pkg.version} -- Copyright (c) 2024-present, Shopify Inc. -- license (MIT): https://github.com/Shopify/shopify-app-js/blob/main/LICENSE.md */`,

?

[paulomarg]

I think we might want to keep it as it was - technically this is still the same package as before, so it still applies from 2023 onward.

[lizkenyon]

Will any of these changes resolve the down compilation of the async await, like mentioned here?

[paulomarg]

Will any of these changes resolve the down compilation of the async await, like mentioned here?

Yes, we'll start building with newer targets and move away from es5, which should hopefully create much more readable transpiled code to use more modern features instead (such as async / await as mentioned in the issue).

[thomfoolery]

I haven't top hatted (are we supposed to?) but it looks good.

Just some question inline below,
and why turbo? I've heard mixed things about turbo.
(I'm assuming we mean this turbo)

[thomfoolery]

Just curious how you landed on ES2021?

Also curious why its the only one missing from the previous list?

[paulomarg]

I was following the TS guide for which target to use for Node 16, which we still technically support. We might want to move that to 2022 when we move on to 18.

Also curious why its the only one missing from the previous list?

Most likely just a mistake on our part, especially since we don't really need to have all of those different lib versions - it might actually be more of a risk if we rely on some invalid types.

[paulomarg]

and why turbo?

We've been using turbo successfully on shopify-api-js for a while now, it gives us a good mix of flexibility and ease of use for now. Since this is already going to be a massive change where we're touching every package, I wanted to err on the safe side and not introduce a whole new tool.

We can always migrate off of turbo later once everything is in place, but for now I'd rather focus on getting better output transpiled code without messing with the toolset.

[thomfoolery]

We've been using turbo successfully on shopify-api-js for a while now

@paulomarg 👍
Sorry, I thought I saw turbo was added as a dependency, didn't realize it was already being used.
Makes sense to stick with what works!

[paulomarg]

We've been using turbo successfully on shopify-api-js for a while now

@paulomarg 👍 Sorry, I thought I saw turbo was added as a dependency, didn't realize it was already being used. Makes sense to stick with what works!

It was only being used on the other repo so far, but the plan is to unify the build / run tools under turbo / rollup and merge the repos so we only have one repo to maintain.

My plan was to:

• Change this repo to build with turbo to ensure our settings for the other repo still made sense
• Get all of the packages building exactly as they were
• Merge the packages folders from both repos
• Ensure everything is building
• Move @shopify/shopify-api away from just tsc and use rollup to have a single process for every package

[paulomarg]

I didn't mention that at first, but this PR is the first step in my list above - I have a couple more changes coming that will get every package in this repo building on turbo + other improvements.

[thomfoolery]

LGTM