Implement Prism -> Sorbet translation for interpolated matches #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Oct 24, 2024
parser/prism/Translator.cc
Outdated
| @@ -645,6 +645,16 @@ unique_ptr<parser::Node> Translator::translate(pm_node_t *node) { | |||
| // Will only work for positive, 32-bit integers | |||
| return make_unique<parser::Integer>(location, std::to_string(intNode->value.value)); | |||
| } | |||
| case PM_INTERPOLATED_MATCH_LAST_LINE_NODE: { // A test of the last read line with interpolation, | |||
There was a problem hiding this comment.
A test? I don't quite get what this means.
There was a problem hiding this comment.
Yeah it's really hard to summarize clearly.
I explain it better in the PR description of #288. Given that, do you have any suggestion for how to summarize it here?
There was a problem hiding this comment.
Thanks for the context, and WOW.
Maybe something like: An interpolated regex in a conditional that checks last read line from IO?
There was a problem hiding this comment.
I had to break it on 2 line to pass the formatter. That gave me some extra room, so I added some more detail:
Suggested change
| case PM_INTERPOLATED_MATCH_LAST_LINE_NODE: { // A test of the last read line with interpolation, | |
| case PM_INTERPOLATED_MATCH_LAST_LINE_NODE: { // An interpolated regex literal in a conditional... | |
| // ...that implicitly checks against the last read line by an IO object, e.g. `if /wat #{123}/` |
egiurleo
approved these changes
Oct 24, 2024
parser/prism/Translator.cc
Outdated
| @@ -645,6 +645,16 @@ unique_ptr<parser::Node> Translator::translate(pm_node_t *node) { | |||
| // Will only work for positive, 32-bit integers | |||
| return make_unique<parser::Integer>(location, std::to_string(intNode->value.value)); | |||
| } | |||
| case PM_INTERPOLATED_MATCH_LAST_LINE_NODE: { // A test of the last read line with interpolation, | |||
amomchilov
force-pushed
the
Alex/translate-last-line-2
branch
from
86e83a6
to
be27986
Compare
amomchilov
force-pushed
the
Alex/translate-last-line-2
branch
from
be27986
to
395f4ea
Compare
amomchilov
force-pushed
the
Alex/translate-last-line-2
branch
from
14b1246
to
5632018
Compare
amomchilov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #288, but for interpolated regexes. Closes #117.