Remove unnecessary task to set BAZEL_EXEC_ROOT
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
reviewed
Oct 29, 2024
amomchilov
changed the title
BAZEL_EXEC_ROOT
|
Can you give me a scenario to verify if that's the case? |
It turns out that we only need `sourceMap`'s value to be set to the workspace folder with any arbitrary key. So not setting `BAZEL_EXEC_ROOT` is fine.
st0012
force-pushed
the
simplify-debugging-actions
branch
from
5ad9e7b
to
8aa17ea
Compare
|
Chatted with @amomchilov and we agree to go ahead first as it's working now. We'll revise the configuration if we found some cases where it causes unwanted noise...etc. |
amomchilov
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we only need
sourceMap's value to be set to the workspace folder with any arbitrary key. So not settingBAZEL_EXEC_ROOTis fine.Motivation
When reviewing #312, I found that having bazel's execroot being the source map key is actually unnecessary. What's required seems to just be the value being the workspace folder. So in this PR I'm removing the task that sets
BAZEL_EXEC_ROOTand updatinglaunch.jsonentries.Test plan
See included automated tests.