fixing constant placement

Signed-off-by: Pedro Tanaka <[email protected]>
Shopify · Sep 16, 2024 · 8e92d4e · 8e92d4e
1 parent f20070c
commit 8e92d4e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/statsd/instrument/aggregator.rb b/lib/statsd/instrument/aggregator.rb
@@ -2,8 +2,6 @@
 
 module StatsD
   module Instrument
-    DEFAULT_MAX_CONTEXT_SIZE = 250
-
     class AggregationKey
       attr_reader :name, :tags, :no_prefix, :type, :hash
 
@@ -26,12 +24,15 @@ def ==(other)
     end
 
     class Aggregator
+      DEFAULT_MAX_CONTEXT_SIZE = 250
+
       CONST_SAMPLE_RATE = 1.0
       COUNT = :c
       DISTRIBUTION = :d
       MEASURE = :ms
       HISTOGRAM = :h
       GAUGE = :g
+      private_constant :COUNT, :DISTRIBUTION, :MEASURE, :HISTOGRAM, :GAUGE, :CONST_SAMPLE_RATE
 
       class << self
         def finalize(aggregation_state, sink, datagram_builders, datagram_builder_class, default_tags)

diff --git a/lib/statsd/instrument/client.rb b/lib/statsd/instrument/client.rb
@@ -157,7 +157,7 @@ def initialize(
         datagram_builder_class: self.class.datagram_builder_class_for_implementation(implementation),
         enable_aggregation: false,
         aggregation_flush_interval: 2.0,
-        aggregation_max_context_size: Aggregator::DEFAULT_MAX_CONTEXT_SIZE
+        aggregation_max_context_size: StatsD::Instrument::Aggregator::DEFAULT_MAX_CONTEXT_SIZE
       )
         @sink = sink
         @datagram_builder_class = datagram_builder_class