Centralize Ruby Version to .ruby-version
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-ma
force-pushed
the
centralize_ruby_version
branch
3 times, most recently
from
01eae29
to
9f175a3
Compare
jenshenny
force-pushed
the
centralize_ruby_version
branch
5 times, most recently
from
ebae4bd
to
d202ea8
Compare
jenshenny
force-pushed
the
centralize_ruby_version
branch
2 times, most recently
from
044d964
to
cc74e31
Compare
Set minimum version of Rubocop to 1.61 This is to support `.ruby-version`: rubocop/rubocop#12645
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
cc74e31
to
4e569a1
Compare
catlee
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setdev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)TargetRubyVersiondefined inrubocop.ymlruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.