Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): move the routers for postmark to not the v2 folder #9597

Open
wants to merge 73 commits into
base: dev
Choose a base branch
from

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Mar 7, 2025

One of the pull request review notes from when these were first made is that they don't belong in the v2 folder. This pr fixes where they are.

Changes 🏗️

  • Moves from v2 to routers for the postmark tooling

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Check that linting and tests pass

majdyz and others added 30 commits February 26, 2025 05:57
…indle/secrt-1120-low-balance-preventing-block-execution
…on' into ntindle/secrt-1119-add-one-click-unsubscribe
@ntindle ntindle requested a review from a team as a code owner March 7, 2025 06:13
@ntindle ntindle requested review from Bentlybro and kcze and removed request for a team March 7, 2025 06:13
Copy link

qodo-merge-pro bot commented Mar 7, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Tag Change

The router tags have been changed from ["v2", "email"] to ["v1", "email"]. Verify this change is intentional and aligns with the API versioning strategy.

tags=["v1", "email"],
prefix="/api/email",

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s and removed Review effort 2/5 labels Mar 7, 2025
Copy link

deepsource-io bot commented Mar 7, 2025

Here's the code health analysis summary for commits 942ac0b..c5ce535. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ Success
❗ 80 occurences introduced
🎯 34 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@ntindle ntindle force-pushed the ntindle/secrt-1117-move-bounce-router-to-somewhere-else branch from ec21488 to 2a7d798 Compare March 7, 2025 06:41
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Mar 7, 2025
Bentlybro
Bentlybro previously approved these changes Mar 7, 2025
Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from ntindle/secrt-1130-add-scheduled-queue to dev March 12, 2025 05:40
@ntindle ntindle dismissed Bentlybro’s stale review March 12, 2025 05:40

The base branch was changed.

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Mar 12, 2025
@AutoGPT-Agent
Copy link

While this PR appears to be a relatively simple move of files from one directory to another to fix code organization, there are some issues:

  1. The PR title and scope match correctly
  2. A user_id check is not applicable here as this is just moving files and updating imports
  3. The test plan could be more comprehensive to ensure routes still work after the move
  4. The PR template is mostly filled out correctly, though some sections could be removed as they aren't applicable (config changes)
  5. The changes appear to be 100% in scope with no extra modifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts platform/backend AutoGPT Platform - Back end size/s
Projects
Status: 👍🏼 Mergeable
Development

Successfully merging this pull request may close these issues.

4 participants