Repository navigation
[MATTER-4641] Phase 1: Add Renode simulation inputs - #1093
Michael Duggan (miduggan24) wants to merge 6 commits into
Conversation
|
bugbot run |
PR SummaryLow Risk Overview The ZynqMP guest is described by Renode scripts wire three machines: Reviewed by Cursor Bugbot for commit 2c1b61e. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: UART2 reuses SDHCI interrupt
- Changed UART2 interrupt from SPI 0x30 (48) to the correct SPI 0x25 (37) per ZynqMP TRM, eliminating the exclusive IRQ conflict with SDHCI0.
Or push these changes by commenting:
@cursor push 0cb0adcf1c
Preview (0cb0adcf1c)
diff --git a/renode_integration/guest/dts/zynqmp-matter-linux.dts b/renode_integration/guest/dts/zynqmp-matter-linux.dts
--- a/renode_integration/guest/dts/zynqmp-matter-linux.dts
+++ b/renode_integration/guest/dts/zynqmp-matter-linux.dts
@@ -1276,17 +1276,17 @@
phandle = <0x6d>;
};
- uart2: serial@ff080000 {
- compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
- status = "okay";
- interrupt-parent = <0x05>;
- interrupts = <0x00 0x30 0x04>;
- reg = <0x00 0xff080000 0x00 0x1000>;
- clock-names = "uart_clk", "pclk";
- power-domains = <0x11 0x21>;
- clocks = <0x04 0x38 0x04 0x1f>;
- phandle = <0xf0>;
- };
+ uart2: serial@ff080000 {
+ compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
+ status = "okay";
+ interrupt-parent = <0x05>;
+ interrupts = <0x00 0x25 0x04>;
+ reg = <0x00 0xff080000 0x00 0x1000>;
+ clock-names = "uart_clk", "pclk";
+ power-domains = <0x11 0x21>;
+ clocks = <0x04 0x38 0x04 0x1f>;
+ phandle = <0xf0>;
+ };
usb0: usb@ff9d0000 {
#address-cells = <0x02>;You can send follow-ups to the cloud agent here.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2c1b61e. Configure here.
8d54e67 to
df0f5ca
Compare
| { | ||
| "renode": { | ||
| "repo": "https://github.com/SiliconLabsSoftware/renode.git", | ||
| "commit": "e3f79c5f869546d6ca65e233fb74bb5f67208e8b" |
There was a problem hiding this comment.
is this something that we would need to keep updating? for all commits in this file. If yes , how often?
There was a problem hiding this comment.
the sha will need to be maintained/updated, but likely not often (perhaps once per release cycle to stay up to date with otbr and base rootfs)
the renode sha can change with each release cycle unless there is some bug/optimization we want to pick up before then
aside from that not much maintenance, the rcp slcp files come directly from sisdk submodule (which may need to change with package manager), ubuntu/mac versions updated in sync with github when they update their runners, etc.
1ffb0f7 to
cbaf988
Compare
d5d1b00 to
806f9d6
Compare
198f90d to
806f9d6
Compare
806f9d6 to
af52492
Compare


Issue Link:
MATTER-4641
Description of Problem/Feature:
Phase 1 of Matter Renode CI artifact work. The build and publish workflow is in Phase 2.
This PR checks in guest and simulation files that phase 2 will consume, matching the current manual Renode setup
Description of Fix/Solution:
Check in the following under
renode_integration/:zynqmp-matter-linux.dts: ZynqMP device tree derived from tree from antmicro extended for Matter HubS99matter-servicesmatter-thread-initchip-toolwrapper (binary built in phase 2)matter-sim-full.resc- cold bootmatter-sim.resc- load from checkpoint and attach Matter SoC at runtimeAlso adds
sim-manifest.jsonto pin versions and RCP configuration, and.gitignorefor build products in phase 2Testing Done:
Manual testing of these simulation inputs as described in the confluence page (these inputs come from the zip file)
https://confluence.silabs.com/spaces/MATTER/pages/878464295/Renode+Simulation