[SL-UP] Refactor Platform WiFi events by rosahay-silabs · Pull Request #1191 · SiliconLabsSoftware/matter_sdk

Rohan Sahay (rosahay-silabs) · 2026-09-12T22:23:57Z

Summary

Move WiFi reconnect/retry out of WifiInterface into ConnectivityManagerImpl, so station connect/disconnect/reconnect is driven by one state machine.
Rename Silabs platform WiFi events (kWFXSystemEvent → kPlatformSLEvent, add public kSLSystemEvent) and replace ConfigureStationMode() with EnableStationMode().
Track last disconnect reason and map SiWx status codes to NetworkCommissioningStatusEnum (NC status reporting still has TODOs to use it).

Related issues

N/A

Testing

manually tested commissioning
reconnection of access point due to loss of access point
reconnection due to device reboot

…improved error handling and clarity. Simplify exit logic by removing unnecessary exit label.

…instead of hardcoded.

… handling to streamline the connection process.

…tials if the station is provisioned before connecting to a new network. Add comments for clarity on the connection process.

…essages for WiFi events and streamline state transitions by removing unnecessary checks. Enhance error handling in setting WiFi station mode and improve clarity in DriveStationState logic.

…itialize mLastDisconnectionReason to kUnknownError for improved error tracking.

Map join/disconnect failures to disconnection reasons and let ConnectivityManager drive station state.

…ation state management

…e-based handling and disconnection logic

…NetworkCommissioningStatusEnum and enhance disconnection notification logic

…thod to streamline reconnection logic in WiFi station state management

…ect status in notifications and improving reason retrieval

…disconnection handling into a single method

…use direct enum references for improved clarity

…streamline shell task initialization

…ialization and state management

…t by replacing TEMPORARY_RETURN_IGNORED with ReturnOnFailure

…ilure with LogErrorOnFailure in WiFi state management and scanning processes

…iguration by consolidating error handling for SSID and PSK

…king status updates and refining state transition checks

… logging for connection and disconnection events

…e reconnection state is reset correctly

sabollim-silabs · 2026-09-22T10:31:13Z

bugbot review

cursor · 2026-09-22T10:31:26Z

PR Summary

High Risk
Changes core WiFi station lifecycle, reconnection, and network commissioning error reporting on Silicon Labs; regressions could affect pairing, reconnect after AP loss/reboot, and ICD/LIT disconnect paths.

Overview
Refactors Silicon Labs WiFi so connect, disconnect, and reconnect are owned by ConnectivityManagerImpl instead of timer-based retries inside WifiInterface.

The station state machine gains explicit auto-connect and pending-disconnect handling, timed reconnect after failures, and a new _DisconnectNetwork() path used by network commissioning. Platform WiFi events are renamed (kWFXSystemEvent → kPlatformSLEvent; public kSLSystemEvent), and station setup moves from ConfigureStationMode() to EnableStationMode() / optional disable. WifiInterface drops its retry timer; SiWx stores the last disconnect reason, maps Si91x status codes to NetworkCommissioningStatusEnum, and reports failures through NotifyDisconnection. SlWiFiDriver loads credentials via RevertConfiguration, routes connects through ConnectivityMgr().DisconnectNetwork() / station mode toggles, and surfaces connect/status callbacks using mapped disconnect reasons instead of auto-committing on success. WiFi shell commands register SlWiFiDriver when SL_WIFI is enabled.

^{Reviewed by Cursor Bugbot for commit 7df0bd3. Configure here.}

cursor

Stale Bugbot comment from a previous run.

…ducing previous state tracking and adjusting auto-connect logic

Rohan Sahay (rosahay-silabs) · 2026-09-22T16:41:25Z

bugbot review

cursor

Stale Bugbot comment from a previous run.

…elated to LIT connect management in ConnectivityManager

Rohan Sahay (rosahay-silabs) · 2026-09-22T18:06:37Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

…cing managed disconnect state and adjusting auto-connect logic

…onnect management in disconnection handling

…WiFi disconnection handling and auto-connect logic

Rohan Sahay (rosahay-silabs) · 2026-09-23T03:08:26Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

…te transitions and improving auto-connect logic

Rohan Sahay (rosahay-silabs) · 2026-09-23T09:43:31Z

bugbot run

cursor

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 7df0bd3. Configure here.}

Rohan Sahay (rosahay-silabs) added 16 commits September 10, 2026 08:38

Update the event message

fb35177

Rename kWFXSystemEvent to kPlatformSLEvent

3517942

Add kSLSystemEvent to PublicPlatformSpecificEventTypes enum

dcdaaf3

TEMP: commit code

6b2d9a4

bugfix name

2e773bf

Replace direct call to EnableStationMode with SetWiFiStationMode for …

d2edeae

…improved error handling and clarity. Simplify exit logic by removing unnecessary exit label.

revert to val

ab29dcb

Adds fix to make SL_ONNETWORK_PAIRING work as default SSID and PSK …

a879333

…instead of hardcoded.

Remove temporary commit configuration call in WiFi network connection…

e44d5d0

… handling to streamline the connection process.

Adding comments for variables

ee46c17

Enhance WiFi connection handling by disconnecting and clearing creden…

f815f0b

…tials if the station is provisioned before connecting to a new network. Add comments for clarity on the connection process.

Refactor WiFi event handling in ConnectivityManagerImpl. Update log m…

478f5c2

…essages for WiFi events and streamline state transitions by removing unnecessary checks. Enhance error handling in setting WiFi station mode and improve clarity in DriveStationState logic.

Add method to retrieve last disconnection reason in WifiInterface. In…

77978db

…itialize mLastDisconnectionReason to kUnknownError for improved error tracking.

Improve readability

c6aca24

refactor(silabs-wifi): move reconnect to ConnectivityMgr

9d61b3e

Map join/disconnect failures to disconnection reasons and let ConnectivityManager drive station state.

refactor(silabs-wifi): move reconnect to ConnectivityMgr

2fcfdf2

Map join/disconnect failures to disconnection reasons and let ConnectivityManager drive station state.

silabs-matter-ci-bot Bot added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Sep 12, 2026

Rohan Sahay (rosahay-silabs) added 3 commits September 13, 2026 21:27

refactor(silabs-wifi): simplify logging and error handling in WiFi st…

d969a55

…ation state management

refactor(silabs-wifi): enhance WiFi station mode management with stat…

e1cf814

…e-based handling and disconnection logic

refactor(silabs-wifi): implement mapping of disconnection reasons to …

779f031

…NetworkCommissioningStatusEnum and enhance disconnection notification logic

Rohan Sahay (rosahay-silabs) self-assigned this Sep 14, 2026

Junior Martinez (jmartinez-silabs) reviewed Sep 14, 2026

View reviewed changes

Rohan Sahay (rosahay-silabs) added 8 commits September 15, 2026 14:00

refactor(silabs-wifi): introduce ResetReconnectionWiFiStationState me…

aeffd16

…thod to streamline reconnection logic in WiFi station state management

refactor(silabs-wifi): add stub for disabling station mode

058fb86

clean up comments

fe95232

refactor(silabs-wifi): streamline disconnection handling by using dir…

1279dc2

…ect status in notifications and improving reason retrieval

refactor(silabs-wifi): simplify disconnection logic by consolidating …

d7bdf7e

…disconnection handling into a single method

refactor(silabs-wifi): update MapToNetworkCommissioningStatusEnum to …

7f96497

…use direct enum references for improved clarity

Adds fix for #26861

2048dde

Adds fix for #26861

b8a63c9

Restyled by whitespace

2d85061

Junior Martinez (jmartinez-silabs) approved these changes Sep 18, 2026

View reviewed changes

Rohan Sahay (rosahay-silabs) added 8 commits September 19, 2026 12:52

refactor(silabs-wifi): remove unused WiFi shell command includes and …

d271b46

…streamline shell task initialization

refactor(silabs-wifi): streamline error handling in WiFi station init…

aa0d6d8

…ialization and state management

refactor(silabs-wifi): enhance error handling in WiFi state managemen…

89658b6

…t by replacing TEMPORARY_RETURN_IGNORED with ReturnOnFailure

refactor(silabs-wifi): improve error handling by replacing ReturnOnFa…

76881db

…ilure with LogErrorOnFailure in WiFi state management and scanning processes

refactor(silabs-wifi): simplify configuration retrieval in RevertConf…

13b08cc

…iguration by consolidating error handling for SSID and PSK

refactor(silabs-wifi): enhance WiFi state management by adding networ…

1d88a90

…king status updates and refining state transition checks

refactor(silabs-wifi): refine WiFi state transition logic and enhance…

553338d

… logging for connection and disconnection events

refactor(silabs-wifi): enhance logging in DriveStationState and ensur…

2cc039a

…e reconnection state is reset correctly

cursor Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/NetworkCommissioningWiFiDriver.cpp

refactor(silabs-wifi): enhance WiFi station state management by intro…

f0ebff6

…ducing previous state tracking and adjusting auto-connect logic

cursor Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/NetworkCommissioningWiFiDriver.cpp

refactor(silabs-wifi): update auto-connect logic and clean up TODOs r…

cc5e992

…elated to LIT connect management in ConnectivityManager

cursor Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Rohan Sahay (rosahay-silabs) added 3 commits September 23, 2026 00:22

refactor(silabs-wifi): improve WiFi disconnection handling by introdu…

9f574d0

…cing managed disconnect state and adjusting auto-connect logic

refactor(silabs-wifi): remove outdated TODO comments related to LIT c…

dcb4084

…onnect management in disconnection handling

refactor(silabs-wifi): introduce disconnect pending state to improve …

393abde

…WiFi disconnection handling and auto-connect logic

cursor Bot reviewed Sep 23, 2026

View reviewed changes

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

refactor(silabs-wifi): enhance disconnection handling by refining sta…

7df0bd3

…te transitions and improving auto-connect logic

cursor Bot reviewed Sep 23, 2026

View reviewed changes

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

Comment thread src/platform/silabs/ConnectivityManagerImpl_WIFI.cpp

sabollim-silabs approved these changes Sep 23, 2026

View reviewed changes

Rohan Sahay (rosahay-silabs) merged commit 287203e into release_2.10-1.6.1 Sep 23, 2026
87 checks passed

Rohan Sahay (rosahay-silabs) deleted the refactor/platform-wifi-events branch September 23, 2026 16:41

Conversation

Rohan Sahay (rosahay-silabs) commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related issues

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sabollim-silabs commented Sep 22, 2026

Uh oh!

cursor Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rohan Sahay (rosahay-silabs) commented Sep 22, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rohan Sahay (rosahay-silabs) commented Sep 22, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Rohan Sahay (rosahay-silabs) commented Sep 23, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rohan Sahay (rosahay-silabs) commented Sep 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rohan Sahay (rosahay-silabs) commented Sep 12, 2026 •

edited

Loading

cursor Bot commented Sep 22, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading