Repository navigation
[SL-UP] Upgrade mbedTLS 3.x to 4.x - #1196
Ricardo Casallas (rcasallas-silabs) wants to merge 1 commit into
Conversation
3db32ec to
df97526
Compare
bd1957e to
f4f5f73
Compare
8e177c7 to
80479d2
Compare
e99074d to
6fc6e37
Compare
37c9bff to
00d6f7a
Compare
573ed22 to
11f297c
Compare
555036e to
61c45e3
Compare
61c45e3 to
d812eaf
Compare
PR SummaryHigh Risk Overview Platform crypto is updated for mbedTLS 4 API breaks: legacy symbols move behind SiWx917 tinycrypt builds add Reviewed by Cursor Bugbot for commit d812eaf. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d812eaf. Configure here.
| psa_cipher_finish(&operation, block.data() + output_len, block.size() - output_len, &final_len); | ||
| psa_destroy_key(key_id); | ||
|
|
||
|
|
There was a problem hiding this comment.
OTA decrypt ignores cipher finish errors
High Severity
Decrypt never checks psa_cipher_finish and always returns success while advancing mIVOffset. PSA CTR can leave the last bytes in finish, and a failed finish must be aborted. Encrypted OTA can then apply a corrupt image or decrypt later chunks with a wrong counter. The same path also runs AES-CTR in place, unlike the working PSA decrypt helper that uses a separate output buffer.
Reviewed by Cursor Bugbot for commit d812eaf. Configure here.


Summary
Upgrade mbedTLS support from 3.x to 4.x:
Related issues
Testing