You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[SL-ONLY] Fixing the Zigbee app build failure - #1215
Low Risk
Single preprocessor guard change for a compile-time constant; no runtime behavior change beyond restoring successful Zigbee app builds.
Overview
Fixes a Silicon Labs Zigbee app build break by changing which preprocessor guard defines kZbLeaveAnnouceDelay in BaseApplication.cpp.
The delay constant was wrapped in #if SL_MATTER_ZIGBEE_SEQUENTIAL, but it is also used on the commissioning-complete path under #ifdef SL_CATALOG_ZIGBEE_STACK_COMMON_PRESENT. Zigbee app builds can have the catalog define without the sequential flag, so the symbol was missing and compilation failed.
The guard now matches SL_CATALOG_ZIGBEE_STACK_COMMON_PRESENT, consistent with other Zigbee includes and the timer use around commissioning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl-onlyThis TAG indicates that this commit is a silabs-specific commit that cannot be upstreamed to CSA.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From the PR: #1207
The define check which was added was incorrect causing build failure
line https://github.com/SiliconLabsSoftware/matter_sdk/blob/main/examples/platform/silabs/BaseApplication.cpp#L1218
Related issues
NA
Testing
Local build of the zigbee app