Repository navigation
Sync csa branch with main - #1253
Merged
Merged
Conversation
…C_AVANALY_2_14 (#74584) * [ZoneManagement][AVAnalysis] Support RemoteZones feature and update TC_AVANALY_2_14 Implement Feature::kRemoteZones (REMZ) validation, storage, and event fields in ZoneManagementCluster, enable kRemoteZones in chip-camera-app, and update TC_AVANALY_2_14 to create and verify remote 2D Cartesian zones with nodeID. Fixes #74496 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ZoneManagement][AVAnalysis] Address Copilot and CodeRabbit review comments on PR #74584 - Reject nodeID/endpointID fields immediately with Status::InvalidCommand in HandleCreateTwoDCartesianZone and HandleUpdateTwoDCartesianZone when the kRemoteZones feature is not enabled, before running capacity or lookup checks. - Preserve existing zone nodeID/endpointID in HandleUpdateTwoDCartesianZone when those optional fields are omitted from the update command, while clearing them when explicitly passed as null. - Add backwards-compatible 4-argument CreateTwoDCartesianZone and UpdateTwoDCartesianZone overloads on ZoneManagement::Delegate so remote zone identifiers are passed to the persistence delegate on create/update. - Expand TestZoneManagementCluster unit tests to cover early InvalidCommand rejection, preserving omitted remote fields on update, and persisting remote zone fields across Shutdown/Startup. - In TC_AVANALY_2_14.py, derive zone vertices within TwoDCartesianMax bounds and wrap post-creation steps in a try/finally block so RemoveZone and stream cleanup always execute on failure. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ZoneManagement][AVAnalysis] Address second-round Copilot review comments on PR #74584 - Return Status::Failure from the default 4-argument CreateTwoDCartesianZone and UpdateTwoDCartesianZone overloads in ZoneManagement::Delegate when non-empty remote zone fields are provided, preventing legacy delegates from silently dropping remote associations. - Update examples/camera-app ZoneManager to store remote zone nodeId and endpointId in TwoDCartZone, implement the 4-argument Delegate overloads, and restore remote zone fields in LoadZones. - In TC_AVANALY_2_14.py, gate Step 2 zone creation on TwoDimensionalCartesianZone (F00) and UserDefined (F02) in addition to RemoteZones (F04), avoid duplicate motion zone geometry when selecting vertices, include CreateTwoDCartesianZone and its response assertions inside the try/finally cleanup block, and propagate RemoveZone cleanup failures. * [ZoneManagement][AVAnalysis] Address marktrayer review comments on PR #74584 - Only enable ZoneManagement::Feature::kRemoteZones on camera-app when launched with --camera-remote-analysis, matching AvAnalysis::Feature::kRemoteContextDetection for CI loopback runs while keeping normal camera-app runs as a standard camera end device. - Forward the default 4-argument CreateTwoDCartesianZone and UpdateTwoDCartesianZone overloads in ZoneManagement::Delegate directly to the 2-argument methods without failing when nodeId or endpointId is present. - Preserve active test-body exceptions during cleanup in TC_AVANALY_2_14.py while propagating cleanup errors when the test body succeeds. * [ZoneManagement] Fix clang-tidy errors in TestZoneManagementCluster and zone-manager --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ed by platform-bot) (#74631) * [NXP][config] Disable by default periodic stats logs print Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * fix PR comment Signed-off-by: Martin Girardot <martin.girardot@nxp.com> --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
…ller-supplied labels for OnOff/LevelControl widgets (#74630) * [all-devices-app][esp32] Caller-supplied labels for the OnOff and LevelControl display widgets The OnOff widget takes its state and button text, and the LevelControl widget the name shown before the level, from the caller. The defaults keep the current Power and Brightness text, so existing device screens are unchanged. * [all-devices-app][esp32] Speaker device screen for the CoreS3 display Adds a Speaker device screen composed from the OnOff and LevelControl cluster widgets, labelled as mute/unmute and volume, so the device type no longer falls back to the no-UI entry in the endpoint list.
* Initial bringup debug * Fix PASE session establishment failure * Config cleanup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Config optimizations for all-device-app commissioning * Config optimizations * Address review comments * Apply batched suggestions from code review Co-authored-by: Matthew Albert <matthew.albert@silabs.com> Co-authored-by: Sergio Soares <sergiosoares@google.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthew Albert <matthew.albert@silabs.com> Co-authored-by: Sergio Soares <sergiosoares@google.com>
…maitained list. Add Ricardo to the maitainers, remove Louis-Philip (#74654)
* Reject zero group ID in Binding entries * Update src/app/clusters/bindings/BindingCluster.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Add Binding group ID validation regression test Verify that whole-list and append writes of kUndefinedGroupId return ConstraintError without adding a binding, and that group 1 remains accepted. Validation: 10 Binding unit tests pass. The regression fails with the pre-fix validation. --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
silabs-matter-ci-bot
Bot
added
changing-git-submodules-on-purpose
sl-require-admin-action
silabs-matter-ci-bot
Bot
added
changing-git-submodules-on-purpose
sl-require-admin-action
Contributor
|
The check for |
Michael Duggan (miduggan24)
approved these changes
Oct 7, 2026
sarthak shaha (Sarthak-Shaha)
approved these changes
Oct 7, 2026
Junior Martinez (jmartinez-silabs)
approved these changes
Oct 8, 2026
Junior Martinez (jmartinez-silabs)
merged commit Oct 8, 2026
e1be758
into
main
113 of 120 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION