Repository navigation
[CSA-CP] [Silabs] : Closure App Refactor (#73283) - #1255
Merged
sarthak shaha (Sarthak-Shaha) merged 1 commit intoOct 13, 2026
Merged
sarthak shaha (Sarthak-Shaha) merged 1 commit into
sarthak shaha (Sarthak-Shaha) merged 1 commit into
Conversation
* [SL-UP] : Closure App Refactor (#983) * fix macros * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix spelling * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename base APIs with suffix default * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix macros * fix the race condition * address comments --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 task done
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 317103735e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Michael Duggan (miduggan24)
approved these changes
Oct 8, 2026
sarthak shaha (Sarthak-Shaha)
added
the
csa-cp
Sergei Lissianoi (selissia)
approved these changes
Oct 13, 2026
sarthak shaha (Sarthak-Shaha)
merged commit Oct 13, 2026
d49f702
into
release_2.10-1.6.1
86 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSA CP : project-chip/connectedhomeip#73283
Summary
Refactor the Silicon Labs Closure App to support the project upgrade architecture and customer customization.
Additional API fixes
Some ClosureManager implementation APIs previously shared names with the APIs exposed through the override layer, preventing the intended overrides from being dispatched correctly. The default implementations have been separated into *Default() APIs to allow the CRTP override path to work as intended.
Related issues
N/A
Testing