Skip to content

[SL-ONLY] Fix labeler job - #1266

Merged
Michael Duggan (miduggan24) merged 2 commits into
mainfrom
fix_labeler
Oct 9, 2026
Merged

Michael Duggan (miduggan24) merged 2 commits into
mainfrom
fix_labeler

Conversation

@miduggan24

Copy link
Copy Markdown
Contributor

Summary

PR #1213 introduced change to run labeler job on pull_request_target to allow for external contributor to run in the context of matter_sdk repo to securely access repo secrets

This change however was not applied on main branch, which still runs on pull_request. Since pull_request_target targets default branch of the repo, and main branch does not have this event type for this job, it never registers.

Apply change to main branch as well

Related issues

NOJIRA

Testing

Future PRs will test

@miduggan24
Michael Duggan (miduggan24) requested a review from a team as a code owner October 9, 2026 14:38
@cursor

cursor Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only workflow trigger and permissions change; no application or runtime code affected.

Overview
Aligns the Silabs Labeler workflow on main with the intended trigger so it actually runs for PRs targeting main and release_*.

The workflow now listens on pull_request_target instead of pull_request, matching the fix from an earlier PR that was never applied on main. That event runs in the base-repo context so the job can use GitHub App credentials and secrets when labeling PRs from external forks. permissions: contents: read is added explicitly for the workflow.

Reviewed by Cursor Bugbot for commit 12691d1. Configure here.

@Sarthak-Shaha

Copy link
Copy Markdown
Contributor

Should have SL-ONLY?

@jmartinez-silabs

Copy link
Copy Markdown
Contributor

it should flag sl-only here

@miduggan24 Michael Duggan (miduggan24) changed the title Fix labeler job [SL-ONLY] Fix labeler job Oct 9, 2026
@miduggan24

Copy link
Copy Markdown
Contributor Author

it should flag sl-only here

omitted for testing, but change won't apply until it actually lives on default branch

@miduggan24
Michael Duggan (miduggan24) merged commit 9fcd3ab into main Oct 9, 2026
110 of 111 checks passed
@miduggan24
Michael Duggan (miduggan24) deleted the fix_labeler branch October 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants