[CSA-CP][Silabs]Restructure Silabs Matter Provisioning implementation. (#74613) by jmartinez-silabs · Pull Request #1268 · SiliconLabsSoftware/matter_sdk

Junior Martinez (jmartinez-silabs) · 2026-10-11T15:55:31Z

Summary

Restructures the Provisioning implementation into a modular, platform-neutral
core library with injectable interfaces for storage, crypto, channel, and
reset handling.

Problem

Our Provisioning library mixed protocol/orchestration logic with
platform-specific storage, crypto/attestation, and transport code.
That coupling forced:
- Per-family library builds (MG24, SI917, …) that depended on
  Simplicity SDK / WiSeConnect.
- A large, hard-to-maintain core that could not be swapped for
  custom storage or crypto without forking the library.
- Silabs library could be broken by Matter sdk changes leading to build errors until the library is updated and published.

Solution

Split platform capabilities behind explicit interfaces consumed by the
core:
- IProvisionStorageReader / IProvisionStorageWriter (read-only vs
  provision/write lifecycle)
- IProvisionCrypto (attestation key ops, hash, CSR, sign)
- IProvisionChannel (byte transport for the provisioning protocol)
- Optional reset handler via Manager::SetResetHandler
Only enable ProvisioningStorageReader implementation is required for a Silabs Matter device to work.
The proprietary provisioning core Library is now built as ABI-profile archives (m4-softfp, m33-hard, plus
optional clang variants) instead of per-MCU-family libs; core no longer
requires SiSDK/WiSeConnect.
Ship Silabs default implementations (storage reader/writer, PSA crypto,
RTT/BLE channels) outside the core

Testing

Confirm Silabs matter device work without the our provisioning library utilizing only the ProvisionStorageReader implementation.
Verified Generator Firmware wiring for Silabs defaults
Manual / board validation: run a full provision session against rebuilt
Generator Firmware for representative EFR32 (m33-hard) and SiWx917 (m4-softfp)
targets to confirm read/write, CSR, and commit paths still succeed.
Confirm devices are commissionable to a matter fabric with the provisionned data and certificates.

sarthak shaha (Sarthak-Shaha) · 2026-10-12T01:09:03Z

A submodule bump in matter_extension should be able to also validate this change?

Junior Martinez (jmartinez-silabs) · 2026-10-14T02:00:56Z

sarthak shaha (@Sarthak-Shaha) It requires some component changes not just a bump.
One SiliconLabsSoftware/matter_extension#1147 is merged I will cherry-pick the same to release_2.10 and bring the matter_sdk bump too

cursor · 2026-10-14T03:02:39Z

PR Summary

High Risk
Changes factory-data reads, DAC signing, Matter provider registration, OTA credential persistence, and provisioning transport—any regression affects commissioning and device attestation.

Overview
Refactors Silicon Labs factory-data and provisioning into read/write/crypto/channel pieces that plug into Provision Core via IProvisionStorageReader, IProvisionStorageWriter, IProvisionCrypto, and IProvisionChannel, instead of one monolithic Storage type.

Runtime wiring: MatterConfig registers ProvisionStorageReader for instance info, commissionable data, and DAC; when the provision channel (or multi-OTA writer path) is enabled, ProvisionManager gets the reader, writer, crypto, and BLE/RTT channel backends. BaseApplication and Zephyr factory-data builds use the reader for QR/setup payload; multi-OTA can persist attestation data through the writer and crypto.

Build/layout: GN provision:storage picks default vs flash backends, compiles in-tree ProvisionCryptoPSA/Mbed and platform channels, and links a single ABI-profile libProvision-*.a instead of per-SoC prebuilt crypto/storage libs. Large deleted ProvisionStorage* sources move into ProvisionStorageReader/Writer plus default/, flash/, and zephyr/ implementations.

Minor: OpenThread Silabs example debug optimization s → g; Kconfig mostly comment/whitespace edits including CHIP_FACTORY_DATA help text for ProvisionStorageReader.

^{Reviewed by Cursor Bugbot for commit d4e6940. Configure here.}

cursor

Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit d4e6940. Configure here.}

* Restructure our Provisioning implementation. This commit restructures the Provisioning implementation to use a more modular approach. Create interfaces splitting each feature into a separate class to call into the core library. The core library is now much more concise and easier to maintain. Offer implementations for each interface that are used by our platform. User could implement their own version of the interfaces to use their own storage, crypto, etc. * Add fix to issue found by copilot * Fix some issues flagged by coderabbit * Update OTAMultiImage to leverage new provision interface. Fix other misc issues * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Potential fix for pull request finding 'Remove trailing backtick from preprocessor directive' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix a conercase with multiota * Address reviewer comments * Bump matter_support to commit merged in offical branch --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix for 917 provisionCrypto with provision flash * [Silabs] Fix 917 Flash provisionStorage. Add condition statement to fix slc based builds * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>

…r sources

Junior Martinez (jmartinez-silabs) · 2026-10-15T14:08:39Z

Last commit was only to bump matter_support to the merged sha. Merging once all silabs apps build are completed.

silabs-matter-ci-bot Bot added the csa-cp This TAG indicates that this commit is a cherry-pick from a CSA commit. label Oct 11, 2026

Junior Martinez (jmartinez-silabs) mentioned this pull request Oct 11, 2026

[Cherry-pick]Restructure our Provisioning implementation (#265) SiliconLabsSoftware/matter_support#272

Merged

Junior Martinez (jmartinez-silabs) added the changing-git-submodules-on-purpose label Oct 11, 2026

Junior Martinez (jmartinez-silabs) marked this pull request as ready for review October 11, 2026 18:01

Junior Martinez (jmartinez-silabs) requested a review from a team as a code owner October 11, 2026 18:01

sarthak shaha (Sarthak-Shaha) approved these changes Oct 12, 2026

View reviewed changes

This was referenced Oct 14, 2026

[CP] Update provision components with the new structure #1147 SiliconLabsSoftware/matter_extension#1155

Closed

[CP] Update provision components with the new structure (#1147) SiliconLabsSoftware/matter_extension#1156

Merged

cursor Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread examples/lighting-app/silabs/openthread.gn

Comment thread examples/platform/silabs/BaseApplication.cpp

Comment thread examples/platform/silabs/provision/default/ProvisionStorageReader.cpp

Ricardo Casallas (rcasallas-silabs) approved these changes Oct 14, 2026

View reviewed changes

Junior Martinez (jmartinez-silabs) and others added 7 commits October 15, 2026 09:19

Point matter_support to commit goin to 2.10 branch

8538ccf

[Silabs] Fix 917 Flash ProvisionStorage (#74702)

defbb13

* Fix for 917 provisionCrypto with provision flash * [Silabs] Fix 917 Flash provisionStorage. Add condition statement to fix slc based builds * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>

Add missing change lost in merge conflict resolution sync commit

6decb57

Update Zephyr all-devices-app CMakeLists with the new provision Reade…

c1657d0

…r sources

use provisionReader in all-device-app

44bb5ee

Bump matter_support to merge commit

86aad89

Junior Martinez (jmartinez-silabs) force-pushed the csa-cp/provision_restructure branch from 9cea849 to 86aad89 Compare October 15, 2026 13:20

Michael Duggan (miduggan24) approved these changes Oct 15, 2026

View reviewed changes

Junior Martinez (jmartinez-silabs) merged commit f83f79e into release_2.10-1.6.1 Oct 15, 2026
86 checks passed

Junior Martinez (jmartinez-silabs) deleted the csa-cp/provision_restructure branch October 15, 2026 14:23

Navigation Menu

Repository navigation

[CSA-CP][Silabs]Restructure Silabs Matter Provisioning implementation. (#74613) - #1268

[CSA-CP][Silabs]Restructure Silabs Matter Provisioning implementation. (#74613)#1268
Junior Martinez (jmartinez-silabs) merged 7 commits into
release_2.10-1.6.1from
csa-cp/provision_restructure

Junior Martinez (jmartinez-silabs) commented Oct 11, 2026

Uh oh!

sarthak shaha (Sarthak-Shaha) commented Oct 12, 2026

Uh oh!

Junior Martinez (jmartinez-silabs) commented Oct 14, 2026

Uh oh!

cursor Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Junior Martinez (jmartinez-silabs) commented Oct 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Junior Martinez (jmartinez-silabs) commented Oct 11, 2026

Summary

Problem

Solution

Testing

Uh oh!

sarthak shaha (Sarthak-Shaha) commented Oct 12, 2026

Uh oh!

Junior Martinez (jmartinez-silabs) commented Oct 14, 2026

Uh oh!

cursor Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Junior Martinez (jmartinez-silabs) commented Oct 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cursor Bot commented Oct 14, 2026 •

edited

Loading