Repository navigation
Sync csa branch with main - #1286
Open
silabs-matter-ci-bot[bot] wants to merge 14 commits into
Open
silabs-matter-ci-bot[bot] wants to merge 14 commits into
silabs-matter-ci-bot[bot] wants to merge 14 commits into
Conversation
…ABLE_WIFIPAF (#74835)
### Summary
Guards NanPeerInfo and ScanTimerCtx in ConnectivityManagerImpl.h with
CHIP_DEVICE_CONFIG_ENABLE_WIFIPAF in addition to
CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONING_PROXY.
#### Problem
- NanPeerInfo and ScanTimerCtx are guarded solely by
CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONING_PROXY.
- When building on Linux with Wi-Fi disabled (chip_enable_wifi = false):
- <glib.h> is not included because CHIP_DEVICE_CONFIG_ENABLE_WPA is 0.
- If CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONING_PROXY is enabled (such as in
all-devices-app), ScanTimerCtx is compiled and fails:
error: unknown type name 'guint'; did you mean 'uint'?
- NanPeerInfo and ScanTimerCtx are Wi-Fi PAF / NAN scan structures used only by
ConnectivityManagerImpl_WiFiPafWpaSupplicant.cpp and methods declared under
CHIP_DEVICE_CONFIG_ENABLE_WIFIPAF && CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONING_PROXY.
#### Solution
- Updated the guard around NanPeerInfo and ScanTimerCtx to:
#if CHIP_DEVICE_CONFIG_ENABLE_WIFIPAF && CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONING_PROXY
- Aligns the struct declarations with the member methods that consume them
(FinishWiFiPAFScan, WiFiPAFScan, mNanScanPeers), preventing compilation of
unused Wi-Fi PAF scan types when Wi-Fi PAF is disabled.
### Testing
- Automated Tests:
- N/A: Compile-time header preprocessor guard fix; no runtime logic was added
or modified. Verified existing Linux platform unit test suite compiles and
runs cleanly:
scripts/run_in_build_env.sh "ninja -C out/linux-x64-tests-clang src/platform/tests:TestPlatformMgr.run"
- Manual Testing:
- Verified compilation of all-devices-app with Wi-Fi disabled
(chip_enable_wifi = false):
scripts/run_in_build_env.sh "ninja -C out/soil-docker"
All 122 targets compiled cleanly without errors.
…p key management (#74807) * Fix TC_SC_5_1 and TC_SC_5_2 when groupcast is Adopted within the group keymanagement cluster. Re-enable SC_5_1 in ci * Move Groupcast adoption check to its own step (0c). Replace Attribute.Revision by Attribute.ClusterRevision
* Fix comments * Fix comment
…/actions/setup-ccache (Auto-merged by bot) Bumps [pyTooling/Actions/with-post-step](https://github.com/pytooling/actions) from 8.5.2 to 9.2.1. - [Release notes](https://github.com/pytooling/actions/releases) - [Changelog](https://github.com/pyTooling/Actions/blob/dev/doc/Releases.rst) - [Commits](pyTooling/Actions@a7d5e20...5bc1085) --- updated-dependencies: - dependency-name: pyTooling/Actions/with-post-step dependency-version: 9.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/actions/dump-disk-info (Auto-merged by bot) Bumps [pyTooling/Actions/with-post-step](https://github.com/pytooling/actions) from 8.5.2 to 9.2.1. - [Release notes](https://github.com/pytooling/actions/releases) - [Changelog](https://github.com/pyTooling/Actions/blob/dev/doc/Releases.rst) - [Commits](pyTooling/Actions@a7d5e20...5bc1085) --- updated-dependencies: - dependency-name: pyTooling/Actions/with-post-step dependency-version: 9.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…merged by bot) Bumps the codeql-action group with 3 updates in the / directory: [github/codeql-action/init](https://github.com/github/codeql-action), [github/codeql-action/analyze](https://github.com/github/codeql-action) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.38.3 to 4.39.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@24c5418...6f2ac81) Updates `github/codeql-action/analyze` from 4.38.3 to 4.39.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@24c5418...6f2ac81) Updates `github/codeql-action/upload-sarif` from 4.38.3 to 4.39.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@24c5418...6f2ac81) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: codeql-action - dependency-name: github/codeql-action/analyze dependency-version: 4.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: codeql-action - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: codeql-action ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…by bot) Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `01380c5` to `c1aaac6`. - [Release notes](https://github.com/ocornut/imgui/releases) - [Commits](ocornut/imgui@01380c5...c1aaac6) --- updated-dependencies: - dependency-name: third_party/imgui/repo dependency-version: c1aaac65e896a45f81f47a4d68f9959e0f86c859 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4824) * initial progress * first increase-decrease commands * adds get_last_attribute_report_value function * draft 1 * draft 2 * updates descriptions and comments * restyled * fixes verify_step_attribute_values fn * add logging to write_setting * fixes feature support logic * adds test steps * restyled * restyled * lint * update scenarios * updates CI args * fix merge * fix merge * lint * updates step class * restyled * refactors steps, fns * restyled * update fn name * fix typo * adds another test scenario * update progress per pr comments * implement baseline value checks * adds case * adds cases * verifies 1st 4 scenarios * adds wrapping tests * refactors and splits lowestOff vs wrap tests * adds baseline values verifications * adds cluster_guard to matter testing support * adds command to turn fan on if on-off cluster if part of the dut * removes test off command * removes unused imports and functions * updates function signatures, return types, and descriptions * removes redundant descriptions * restyled checkpoint * restyled * lint * refactor for better test step flow * refactor for better test step flow * restyled * cosmetics * adds current values checks * restyled * restyled * lint * lint * implemented lowestOff testing for current values * checkpoint * current and non-current attribute testing * implements test steps * adjust comments * restyyled * restyled * update * restyled * restyled * restyled * cleanup * adds endpoint 1 to CI args * removes await_all_final_values_reported_threshold fn * adds get_attribute_value_from_queue * restyled * restyled * restyled * Update src/python_testing/TC_FAN_3_5.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_FAN_3_5.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_FAN_3_5.py Co-authored-by: C Freeman <cecille@google.com> * fix merge/imports * restyled * address pr comments * rename to lowest_off_field_conditions_test * removes reduntant lines * removes commented line * restyled * removes initialize_percent_setting * lowest_off_field_conditions_test adds clarifying comment on * updates cluster_guard docstring * Update src/python_testing/TC_FAN_3_5.py Co-authored-by: C Freeman <cecille@google.com> * mypy * test formatting * Restyled by autopep8 * updates test steps * format test * updating test steps progress * Restyled by autopep8 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * swaps cluster_guard for cluster_present * step wording updated * cr * cr * fix imports, adds all_of fn and unit test * cr * cr * fix step numbers * fix logging * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updates copyright year * lint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removes temp file * Remove accidentally committed test artifacts * Revert accidental third_party submodule changes * updated to not assume 100% * pr comment * gate subs * spelling * updates script * fix test step text * TC-FAN-3.5 - Rename the script to TC_FAN_3_5_provisional so it does not replace TC-FAN-3.5 in the Test Harness * TC-FAN-3.5 - Rename the test class and methods to TC_FAN_3_5_provisional * Fix TC-FAN-3.5 step 10b to save the ascending baseline --------- Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* [Linux] Bound Wi-Fi connects by ConnectMaxTimeSeconds and report why they fail A connect to a missing SSID never returned, and every failure was kUnknownError. A 30 s deadline now reports kNetworkNotFound, a wrong passphrase reports kAuthFailure, and the failed network is disabled so wpa_supplicant's retries no longer reject scans. CurrentNetwork is read from wpa_supplicant instead of the stale proxy cache, and scan results are sorted by RSSI. * [Linux] Disable a failed network only for a pending ConnectNetwork A failed reconnect that wpa_supplicant started by itself also reached the connect-failure path and disabled the configured network, leaving a commissioned device offline. * Apply batched suggestions from code review Co-authored-by: Sergio Soares <sergiosoares@google.com> * [Linux] Run post-connect handling when the connect timer finds the link up When wpa_supplicant reports 'completed' without 'associating', the timer now also runs PostNetworkConnect(). Scan results are sorted with std::sort. * [Linux] Count every wpa_supplicant association state toward a connect wpa_supplicant coalesces State signals, so 'associating' can be missed. The attempt now starts after the old network is gone, and PAF resumes only once a failed network is disabled. --------- Co-authored-by: Sergio Soares <sergiosoares@google.com>
…… (#74861) * Autogenerated updates for operationalcredentials::certificatechainrequest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fix device type revision parse * Address review comments on device type revision parsing * Refactor conformance parsing context to enum and enforce strict device type revision checks - Replace boolean is_device_type with ConformanceParseContext enum (CLUSTER, DEVICE_TYPE) in ConformanceParseParameters, parse_basic_callable_from_xml, and callers. - Add comprehensive docstrings for ConformanceParseParameters attributes and mapping types. - Enforce strict device type revision evaluation in device_type_revision.get_value(), raising ConformanceException when device_type_revision is None. - Default EmptyClusterGlobalAttributes to device_type_revision=uint(1) for safe fallback in general conformance checks. - Pass EmptyClusterGlobalAttributes(device_type_revision=uint(d.revision)) in generate_spec_xml.py. - Update TestConformanceSupport unit tests for ConformanceParseContext and exception handling.
silabs-matter-ci-bot
Bot
added
changing-git-submodules-on-purpose
sl-require-admin-action
Contributor
|
The check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION