Refactor CMake with JRL CMake Modules v2 (v2) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifoldFR
reviewed
Jan 9, 2026
Member
ManifoldFR
left a comment
ManifoldFR
left a comment
There was a problem hiding this comment.
Seems good to me overall 😄
CMakeLists.txt
Outdated
Comment on lines
185
to
193
| if(BUILD_WITH_CHOLMOD_SUPPORT) | ||
| target_link_libraries(nanoeigenpy PRIVATE SuiteSparse::CHOLMOD) | ||
| target_compile_definitions(nanoeigenpy PRIVATE NANOEIGENPY_HAS_CHOLMOD) | ||
| endif() | ||
|
|
||
| if(BUILD_WITH_ACCELERATE_SUPPORT AND APPLE) | ||
| target_link_libraries(nanoeigenpy PRIVATE Accelerate::Accelerate) | ||
| target_compile_definitions(nanoeigenpy PRIVATE NANOEIGENPY_HAS_ACCELERATE) | ||
| endif() |
Member
There was a problem hiding this comment.
Yeah that's good, it's cleaner than what I was doing before in fwd.hpp. I think the definitions should be public however?
Some users might want to consume the omnibus <nanoeigenpy/decompositions.hpp> header downstream, but it requires the defines to exist for the cholmod/accelerate wrappers to be pulled in.
Contributor
Author
There was a problem hiding this comment.
Definitely a mistake here. Added the dependencies to the nanoeigenpy_headers target. We now export the dependencies correctly. Thanks.
CMakeLists.txt
Outdated
| jrl_option(INSTALL_DOCUMENTATION "Generate and install the documentation" OFF) | ||
|
|
||
| jrl_option(BUILD_WITH_CHOLMOD_SUPPORT | ||
| "Build EigenPy with the Cholmod (LGPL) support. See CHOLMOD/Doc/License.txt for further details." OFF |
Member
There was a problem hiding this comment.
Suggested change
| "Build EigenPy with the Cholmod (LGPL) support. See CHOLMOD/Doc/License.txt for further details." OFF | |
| "Build nanoeigenpy with support for Cholmod (LGPL). See CHOLMOD/Doc/License.txt for further details." OFF |
We had copied the comment string over from the original Eigenpy, and forgot to change it 😅
CMakeLists.txt
Outdated
| ) | ||
|
|
||
| jrl_option(BUILD_WITH_ACCELERATE_SUPPORT | ||
| "Build EigenPy with the Accelerate support (Apple only)" OFF |
Member
There was a problem hiding this comment.
Suggested change
| "Build EigenPy with the Accelerate support (Apple only)" OFF | |
| "Build nanoeigenpy with support for the Accelerate framework (Apple only)" OFF |
auto-merge was automatically disabled
January 10, 2026 07:25
Pull request was converted to draft
gersemirc: put back gersemi definitions no chance observed in this repo. Its for future proofness.
ignore nix result ignore conda generated files
use set_property for multiline env fetch jrl-cmakemodules if not found, tmp solution
add missing COMMAND to check if command is available add a check for the python module name inside the lib no need to compile python files, we don't have any include stubs pyi files in installation
on ubuntu 24.04 the nanobind-dev package brind an old incompatible version 1.9.2-1 fallback to fetchcontent if nanobind 2.5.0 is not found. we mimic the upstream behavior, but using fetchcontent instead of submodules
look for version >=1.1.2 of the jrl we havent updated the version number yet
if we apt install nanobind-dev on ubuntu 24, we get nanobind 1.9.1, which does not ship version from the config file require python 3.11 for stubs generation ROS Humble not supported use VERSION_GREATER_EQUAL and use correct python var add BUILD_TESTING so it appears in the summary
disabling cache for testing
pixi.toml: remove duplicated nanoeigenpy
Otherwise the lib is install in %PREFIX%/Library/Lib/site-packages/nanoeigenpy.pyd But we need %PREFIX%/Lib/site-packages/nanoeigenpy.pyd
we only need the minimum version to be set to enable the correct policies
It was always required from nanobind
we now export eigen and cholmod correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.
c++17minimum requiredpytestNOTE: This the commit are cherry-picked and squashed from the previously accidentitaly merged #28