-
Notifications
You must be signed in to change notification settings - Fork 4
Python backend #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Python backend #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2c1655 to
14650cf
Compare
zivy
requested changes
Mar 13, 2025
blowekamp
reviewed
Apr 1, 2025
blowekamp
reviewed
Apr 1, 2025
blowekamp
reviewed
Apr 3, 2025
blowekamp
reviewed
Apr 22, 2025
Member
blowekamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good. One minor comment regarding the testing.
blowekamp
reviewed
Apr 22, 2025
1e18d37 to
fd0cb06
Compare
This is a major re-write of the code. It now uses pyspellchecker, a pure Python package, replacing pyenchant, which required the C enchant library underneath. Also code has been re-organized to make seperate functions into smaller, more manageable parts and to adhere to Pylint's coding standards.
blowekamp
approved these changes
May 15, 2025
Member
blowekamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and seem to follow Python conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.