-
-
Notifications
You must be signed in to change notification settings - Fork 0
Plugin Rewrite #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RhythmicSys
wants to merge
40
commits into
master
Choose a base branch
from
save-handler-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed: - simplenick.nick.reset - simplenick.nick.delete - simplenick.admin.set.basic - simplenick.admin.set.full - simplenick.admin.set.restrictive
… added admin reset command and nick reload command, added nickname protection check and adjusted username protection check to use plugin's save system and not bukkit's.
…ed it to a command)
…splayName' to more accurately explain what it does
- Changes NickUtils to use static methods, rather than be a singleton class - Removes migrate command - migration is implemented back on enable instead
- Change constants to permission enum - fixed issue where database connection was not closed on disable
Changed placeholder expansion version, and identifier to be consistent with the permission naming
- fix permissions not working properly - add configuration options for what requires permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big Changes
Saving now uses SQL to store data, allowing easier indexing
This allows three new config options:
nickname-protection.online.enabled
(Prevents people from setting the same nickname as someone else who is online)nickname-protection.offline.enabled
(Prevents people from setting the same nickname as someone regardless whether they're online or not)nickname-protection.offline.expires
(How many days a nickname should be protected for, if the person doesn't log in)Other new config options:
require-permission
nick
: whether the basic nickname commands should require permissions set by a permission plugincolor
: Whether nicknames can have color without having permissions set by a permission pluginformat
: Whether nicknames can have formatting without having permissions set by a permissions pluginwho
: Whether you can look up who a user is based on their nickname without having permissions set by a permissions pluginNew Commands:
/nick who <nickname>
tells you the username of the player with the supplied nickname/nick save
can now take in an argument, so you can now do/nick save <nickname>
if you want to save something that isn't your current nickname/nick admin lookup <username>
will display a user's current nickname, as well as their saved nicknamesChanged Commands (Admin Commands)
/nick admin set <username> <nickname>
/nick admin reset <username>
Removed:
Permission Changes:
simplenick.bypass.nick-protection
- Allows bypassing the new nick protection optionsPlaceholder API changes:
simplenick
to be consistent with the permissions and other naming schemesprefixed-mininick
andprefixed-nickname