Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in malicious code scan #1341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix bug in malicious code scan #1341

wants to merge 1 commit into from
+1 −1

Conversation

shoebham
Copy link

@shoebham shoebham commented Aug 28, 2024 •
edited
Loading

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 28, 2024
@ArslanSaleem
Copy link
Collaborator

@shoebham Thanks for the identifying that but this change won't be able to handle scenarios like "import pandas.io" it can still use os and io library from whitelisted libraries to attack.

@ArslanSaleem
Copy link
Collaborator

@shoebham also let's add some test cases as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_is_malicious_code doesn't look for whole word
2 participants
@shoebham @ArslanSaleem