SixLabors · JimBobSquarePants · Feb 10, 2025 · Feb 4, 2025 · Feb 4, 2025 · Feb 4, 2025
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -146,7 +146,7 @@ jobs:
           XUNIT_PATH: .\tests\ImageSharp.Tests # Required for xunit
 
       - name: Export Failed Output
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: actual_output_${{ runner.os }}_${{ matrix.options.framework }}${{ matrix.options.runtime }}.zip

diff --git a/src/ImageSharp/Formats/Gif/LzwDecoder.cs b/src/ImageSharp/Formats/Gif/LzwDecoder.cs
diff --git a/tests/ImageSharp.Tests/Formats/Gif/GifDecoderTests.cs b/tests/ImageSharp.Tests/Formats/Gif/GifDecoderTests.cs
@@ -334,4 +334,16 @@ public void IssueTooLargeLzwBits<TPixel>(TestImageProvider<TPixel> provider)
         image.DebugSaveMultiFrame(provider);
         image.CompareToReferenceOutputMultiFrame(provider, ImageComparer.Exact);
     }
+
+    // https://github.com/SixLabors/ImageSharp/issues/2859
+    [Theory]
+    [WithFile(TestImages.Gif.Issues.Issue2859_A, PixelTypes.Rgba32)]
+    [WithFile(TestImages.Gif.Issues.Issue2859_B, PixelTypes.Rgba32)]
+    public void Issue2859_LZWPixelStackOverflow<TPixel>(TestImageProvider<TPixel> provider)
+        where TPixel : unmanaged, IPixel<TPixel>
+    {
+        using Image<TPixel> image = provider.GetImage();
+        image.DebugSaveMultiFrame(provider);
+        image.CompareToReferenceOutputMultiFrame(provider, ImageComparer.Exact);
+    }
 }
diff --git a/tests/ImageSharp.Tests/TestImages.cs b/tests/ImageSharp.Tests/TestImages.cs
@@ -535,6 +535,8 @@ public static class Issues
             public const string Issue2450_B = "Gif/issues/issue_2450_2.gif";
             public const string Issue2198 = "Gif/issues/issue_2198.gif";
             public const string Issue2758 = "Gif/issues/issue_2758.gif";
+            public const string Issue2859_A = "Gif/issues/issue_2859_A.gif";
+            public const string Issue2859_B = "Gif/issues/issue_2859_B.gif";
         }
 
         public static readonly string[] Animated =

diff --git a/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_A.gif/00.png b/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_A.gif/00.png
diff --git a/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/00.png b/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/00.png
diff --git a/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/01.png b/.../GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/01.png
diff --git a/tests/Images/Input/Gif/issues/issue_2859_A.gif b/tests/Images/Input/Gif/issues/issue_2859_A.gif
diff --git a/tests/Images/Input/Gif/issues/issue_2859_B.gif b/tests/Images/Input/Gif/issues/issue_2859_B.gif
diff --git a/tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs b/tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs
 public abstract class SIMDBenchmarkBase<T>
    where T : struct
 {
    protected T[] input;

    protected T[] result;

    protected T testValue;

    protected Vector<T> testVector;

    protected virtual T GetTestValue() => default;

diff --git a/tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs b/tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs
 public abstract class ToVector4<TPixel>
    where TPixel : unmanaged, IPixel<TPixel>
 {
    protected IMemoryOwner<TPixel> source;

    protected IMemoryOwner<Vector4> destination;

    protected Configuration Configuration => Configuration.Default;

diff --git a/tests/ImageSharp.Benchmarks/Processing/Resize.cs b/tests/ImageSharp.Benchmarks/Processing/Resize.cs
 public abstract class Resize<TPixel>
    where TPixel : unmanaged, IPixel<TPixel>
 {
    private byte[] bytes = null;

    private Image<TPixel> sourceImage;

diff --git a/tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs b/tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs
 public abstract class FromVector4<TPixel>
    where TPixel : unmanaged, IPixel<TPixel>
 {
    protected IMemoryOwner<Vector4> source;

    protected IMemoryOwner<TPixel> destination;

    protected Configuration Configuration => Configuration.Default;
	public abstract class SIMDBenchmarkBase<T>
	where T : struct
	{
	protected T[] input;
Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 13 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected T[] result;
Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 15 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected T testValue;
Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected Vector<T> testVector;
Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/General/Vectorization/SIMDBenchmarkBase.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected virtual T GetTestValue() => default;
	public abstract class ToVector4<TPixel>
	where TPixel : unmanaged, IPixel<TPixel>
	{
	protected IMemoryOwner<TPixel> source;
Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 17 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected IMemoryOwner<Vector4> destination;
Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Bulk/ToVector4.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected Configuration Configuration => Configuration.Default;
	public abstract class Resize<TPixel>
	where TPixel : unmanaged, IPixel<TPixel>
	{
	private byte[] bytes = null;
Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)` Check warning on line 19 in tests/ImageSharp.Benchmarks/Processing/Resize.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Member 'bytes' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)`

	private Image<TPixel> sourceImage;
	public abstract class FromVector4<TPixel>
	where TPixel : unmanaged, IPixel<TPixel>
	{
	protected IMemoryOwner<Vector4> source;
Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 21 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected IMemoryOwner<TPixel> destination;
Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, macos-13, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, macos-13, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, windows-latest, net6.0, 6.0.x, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)` Check warning on line 23 in tests/ImageSharp.Benchmarks/Bulk/FromVector4.cs GitHub Actions / Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false) `Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)`

	protected Configuration Configuration => Configuration.Default;