-
Notifications
You must be signed in to change notification settings - Fork 18
Bazel module support #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bazel module support #135
Conversation
git_override( | ||
module_name = "skywalking-data-collect-protocol", | ||
commit = "fb3fb005650e2489164978b7804117c7ade1529a", | ||
remote = "https://github.com/apache/skywalking-data-collect-protocol.git", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice, this is pointing to skywalking-data-collect-protocol last commit, to confirm its bazel mode migration and will be working properly when its next tag is published
See https://bazel.build/rules/lib/globals/module#git_override for more
/cc @wbpcode |
148823a
to
78828eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project from Bazel WORKSPACE to Bzlmod module system, following the official Bzlmod Migration Guide. The changes update dependency management, version pins, and build configuration to work with the new module system.
- Adds MODULE.bazel file with module dependencies using bazel_dep declarations
- Updates dependency versions across all external libraries (grpc, protobuf, googletest, etc.)
- Modifies build configuration to enable bzlmod and enforce C++17 standard
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
MODULE.bazel | New module file defining dependencies with bazel_dep and git_override |
WORKSPACE.bzlmod | New workspace file for bzlmod compatibility |
.bazelrc | Enables bzlmod and enforces C++17 standard across platforms |
.bazelversion | Updates Bazel version from 4.0.0 to 7.6.1 |
bazel/repositories.bzl | Updates dependency versions and URLs to match MODULE.bazel |
WORKSPACE | Removes rules_proto_toolchains and adds protobuf_deps |
cpp2sky/BUILD | Updates protobuf import to use new location |
bazel/fmtlib.BUILD | Renames target from "fmtlib" to "fmt" |
bazel/spdlog.BUILD | Updates dependency reference to match renamed fmt target |
test/tracing_context_test.cc | Updates include path for protocol buffer headers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
I believe the jobs don’t start because github doesn’t supports Ubuntu 20.04 anymore, I opened #136 I'll have to adapt this PR once the other is merged. |
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
@wbpcode , |
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
@wbpcode , |
Signed-off-by: Matthieu MOREL <[email protected]>
I restored the sudo calls for cmake, we shall be closer to success with that change. |
Signed-off-by: Matthieu MOREL <[email protected]>
Removed C++ standard specification from cmake commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. LGTM. Hope CI is happy.
f045dd0
to
de1e98d
Compare
@wbpcode , I believe this was related to c++ version being 11 instead of 17. |
40be5f9
to
72b89e2
Compare
…ing CI workflow Signed-off-by: Matthieu MOREL <[email protected]>
b455b89
to
32e0499
Compare
@wbpcode, |
…azel coverage Signed-off-by: Matthieu MOREL <[email protected]>
…M version Signed-off-by: Matthieu MOREL <[email protected]>
@wbpcode , |
…paths Signed-off-by: Matthieu MOREL <[email protected]>
🙏 |
…solution Signed-off-by: Matthieu MOREL <[email protected]>
@wbpcode , Working locally, let's hope that's final round on this. |
3a5afb7
to
2806210
Compare
…sistency and add lld Signed-off-by: Matthieu MOREL <[email protected]>
@wbpcode , |
Description
This setup bazel module support. It follows Bzlmod Migration Guide
Notice:
Closes #136