Fix and document backtracking in ltac2-tc-dispatch - #121
Draft
Janno wants to merge 2 commits into
Draft
Conversation
Janno
force-pushed
the
janno/discharge-hints
branch
from
April 24, 2026 11:08
f2efa77 to
86a78fb
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e8e81bb |
| fmdeps/auto/ | main | 26885ed |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | e9a69cc |
| bluerock/bhv/ | skylabs-main | e1da62f |
| fmdeps/brick-libcpp/ | main | e96a0fc |
| fmdeps/ci/ | main | 749706e |
| vendored/elpi/ | skylabs-master | aa4475f |
| vendored/flocq/ | skylabs-master | cf9cc84 |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | e17f6db |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | a5fa400 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 76acc2f |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| fmdeps/rocq-agent-toolkit/ | main | 3bed8c2 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 62d34c3 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 123356.6 | 123360.8 | +4.3 | total |
| +0.00% | - | 1.3 | +1.3 | ├ newly appeared files (1) |
| +0.00% | 123359.6 | 123356.6 | +3.0 | └ common files |
| -0.00% | 22637.5 | 22637.5 | -0.0 | ├ translation units |
| +0.00% | 100722.1 | 100719.1 | +3.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.90% | 196.2 | 198.0 | +1.8 | fmdeps/auto/rocq-skylabs-auto-core/tests/subgoals.v |
| +0.00% | 123356.6 | 123360.8 | +4.3 | total |
| +0.00% | - | 1.3 | +1.3 | ├ newly appeared files (1) |
| +0.00% | 123359.6 | 123356.6 | +3.0 | └ common files |
| -0.00% | 22637.5 | 22637.5 | -0.0 | ├ translation units |
| +0.00% | 100722.1 | 100719.1 | +3.0 | └ proofs and tests |
Janno
force-pushed
the
janno/discharge-hints
branch
from
April 27, 2026 14:08
86a78fb to
4af77e7
Compare
| Ltac2 resolve_dbs dbs t := | ||
| Control.once (fun () => resolve_dbs_all dbs t). | ||
|
|
||
| #[deprecated(since="20260424", note="Use [resolve_dbs] or [resolve_dbs_all]")] |
Contributor
There was a problem hiding this comment.
Since this isn't really published yet, it probably makes sense to avoid deprecated functions at this point. If we don't want people to use this, then we should just remove it.
gmalecha-at-skylabs
approved these changes
Apr 28, 2026
Contributor
|
@Janno how do you feel about getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.