[DO-NOT-MERGE] search control GC PoC by peterInTown · Pull Request #2609 · Skyscanner/backpack-android

peterliu (peterInTown) · 2026-02-24T11:18:29Z

Force commit
Force commit
Force commit
edit swap button theme
finish bpkswitch implmentation
add bpkdivider

Check this if you have read and followed the contributing guidelines

Remember to include the following changes:

Component README.md
Tests

If you are curious about how we review, please read through the code review guidelines

skyscanner-backpack-bot · 2026-02-24T11:19:24Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 2b4a16b

Copilot

Pull request overview

This PR appears to be a PoC/iteration for “search control” UI work in Backpack Compose, adding a new BpkSwapButton component, extending BpkSearchInputSummary to support configurable corner rounding, and enhancing a few supporting components/demos.

Changes:

Add BpkSwapButton (Compose component), demo story, README, and snapshot tests.
Add BpkSearchInputSummaryRounding and thread rounding through to the underlying text field shape.
Extend BpkSwitch with optional trailing icon + click handling, and add color support; allow BpkDivider color override.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/textfield/internal/BpkTextFieldImpl.kt	Threads a new rounding parameter through to the textfield shape.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/switch/BpkSwitch.kt	Adds optional icon + click handling and a color override for switch label content.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/swapbutton/README.md	New component documentation for `BpkSwapButton`.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/swapbutton/BpkSwapButton.kt	New `BpkSwapButton` component implementation.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/searchinputsummary/BpkSearchInputSummary.kt	Adds rounding API for `BpkSearchInputSummary`.
backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/divider/BpkDivider.kt	Adds an optional `color` parameter for divider customization.
app/src/test/java/net/skyscanner/backpack/compose/swapbutton/BpkSwapButtonTest.kt	Adds snapshot tests and a basic click interaction test for swap button.
app/src/main/java/net/skyscanner/backpack/demo/compose/SwitchStory.kt	Demonstrates the new switch icon API.
app/src/main/java/net/skyscanner/backpack/demo/compose/SwapButtonStory.kt	Adds demo story for the new swap button component.
app/src/main/java/net/skyscanner/backpack/demo/compose/BpkSearchInputSummaryStory.kt	Adds a “corner rounding” demo and threads rounding through the story helper.
app/src/main/java/net/skyscanner/backpack/demo/components/SwapButtonComponent.kt	Registers component marker for demo/story tooling.
.idea/deviceManager.xml	Adds IDE configuration file (should not be committed).

Files not reviewed (1)

.idea/deviceManager.xml: Language not supported

Comments suppressed due to low confidence (1)

app/src/main/java/net/skyscanner/backpack/demo/compose/BpkSearchInputSummaryStory.kt:262

SearchInputSummaryStory still takes a name parameter, but it’s no longer used (the heading label was removed). Please remove the parameter or restore using it so we don’t keep dead/unused API in the demo code.

internal fun SearchInputSummaryStory(
    name: String,
    modifier: Modifier = Modifier,
    searchInputSummaryModifier: Modifier = Modifier,

Copilot · 2026-02-24T11:27:12Z

+                    tint = color,
+                )


tint = color is always applied to the icon. With the default color = Color.Unspecified, this bypasses LocalContentColor from BpkToggleableContent and can render the icon with its intrinsic (often black) color (notably wrong in DarkMode). Consider using LocalContentColor.current when color is Unspecified, or only overriding tint when a real color is provided.

Copilot · 2026-02-24T11:27:13Z

    interactionSource: MutableInteractionSource = remember { MutableInteractionSource() },
+    icon: BpkIcon? = null,
+    onIconClick: (() -> Unit)? = null,
    content: @Composable RowScope.(Boolean) -> Unit,


The icon and onIconClick parameters on the overload that accepts a content lambda are not used inside the function body, making the public API confusing. Either remove them from this overload or integrate them into the layout/contract so callers can actually get the icon behavior.

Copilot · 2026-02-24T11:27:13Z

+                if (enabled) {
+                    role = Role.Button
+                }
+            },


The semantics currently set role only when enabled, and do not mark the component as disabled when enabled = false. For accessibility, set the role consistently and add disabled() semantics when not enabled so screen readers announce the disabled state.

Copilot · 2026-02-24T11:27:13Z

+BpkSwapButton includes comprehensive tests covering:
+
+- Visual snapshots in light and dark themes
+- Interaction behavior (click handling)
+- Disabled state rendering
+- Accessibility semantics


The README claims "comprehensive tests" including accessibility semantics, but the added test class only does snapshots plus a click without assertions (and no semantics checks). Please either add the stated test coverage or tone down this section so it matches what is actually tested.

Suggested change

BpkSwapButton includes comprehensive tests covering:

- Visual snapshots in light and dark themes

- Interaction behavior (click handling)

- Disabled state rendering

- Accessibility semantics

BpkSwapButton currently has automated tests covering:

- Visual snapshots in light and dark themes

- Basic interaction behavior (click handling)

Copilot · 2026-02-24T11:27:14Z

+    @Test
+    @Variants(BpkTestVariant.Default, BpkTestVariant.DarkMode)
+    fun canvasDefault() {


Snapshot tests for new components typically include an RTL variant in addition to Default/DarkMode. Adding BpkTestVariant.Rtl coverage here will help catch layout/RTL regressions early.

Copilot · 2026-02-24T11:27:16Z

+            name = "Croner",
+            inputText = "",
+            inputHint = "Thurs 9 May - Fri 29 May, 2025",
+            prefix = Prefix.Icon(BpkIcon.Calendar),
+            rounding = BpkSearchInputSummaryRounding.NoRoundedCorners,


Typo in the story name: "Croner" should be "Corner".

Copilot · 2026-02-24T11:27:17Z

+            name = "Croner",
+            inputText = "",
+            inputHint = "2 adults, 1 child",
+            prefix = Prefix.Icon(BpkIcon.Family),
+            rounding = BpkSearchInputSummaryRounding.BottomCorners,


Typo in the story name: "Croner" should be "Corner".

Copilot · 2026-02-24T11:27:17Z

+    // BpkIcon.InformationCircle would be used here when the icon extensions are properly exposed
+    // For now, here's the API usage example:


The comment about icon extensions "not properly exposed" is misleading now that BpkIcon.InformationCircle is being used via the tokens import. Please remove or update this comment to reflect the current state.

Suggested change

// BpkIcon.InformationCircle would be used here when the icon extensions are properly exposed

// For now, here's the API usage example:

// Example of a switch with an info icon.

Copilot · 2026-02-24T11:27:17Z

+<project version="4">
+  <component name="DeviceTable">
+    <option name="columnSorters">
+      <list>
+        <ColumnSorterState>
+          <option name="column" value="Name" />
+          <option name="order" value="ASCENDING" />
+        </ColumnSorterState>
+      </list>
+    </option>
+  </component>
+</project>


IDE-generated .idea/deviceManager.xml should not be committed to the repository. Please remove this file from the PR and add it to .gitignore if it isn’t already ignored.

Suggested change

<project version="4">

<component name="DeviceTable">

<option name="columnSorters">

<list>

<ColumnSorterState>

<option name="column" value="Name" />

<option name="order" value="ASCENDING" />

</ColumnSorterState>

</list>

</option>

</component>

</project>

skyscanner-backpack-bot · 2026-02-26T12:53:38Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 479aadc

skyscanner-backpack-bot · 2026-02-26T12:58:28Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against c8c324f

skyscanner-backpack-bot · 2026-02-26T14:33:47Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against b7eac94

skyscanner-backpack-bot · 2026-02-26T15:05:08Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 8a93615

skyscanner-backpack-bot · 2026-02-26T15:08:51Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against d2e72fd

skyscanner-backpack-bot · 2026-02-26T15:37:28Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 8b9cecc

skyscanner-backpack-bot · 2026-02-26T15:39:02Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 767b539

skyscanner-backpack-bot · 2026-02-26T16:02:42Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 7d084db

skyscanner-backpack-bot · 2026-03-03T10:25:13Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 72c0f11

skyscanner-backpack-bot · 2026-03-03T11:40:47Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against fa06550

skyscanner-backpack-bot · 2026-03-05T12:12:05Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against feabf92

skyscanner-backpack-bot · 2026-03-06T13:49:05Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 41de577

Co-authored-by: Copilot <Copilot@github.com>

Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-authored-by: Claude <noreply@anthropic.com>

…zation - Add horizontalPadding, contentPadding, and minHeight parameters to BpkSearchInputSummary - Support iconTint and textTint for color customization - Update default minHeight to 56dp (BpkSpacing.Xxl + BpkSpacing.Base) - Update CornerExample to match Figma design with grouped search inputs - Remove spacing between fields for seamless grouped appearance - Update text hints to match Figma mockup (London Heathrow, Barcelona, dates, passengers) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

- Create BpkSwitchStyle sealed class with Default and OnContrast variants - Add style parameter to all BpkSwitch overloads - Implement OnContrast colors for dark background compatibility - Add OnContrastUncheckedSwitchExample and OnContrastCheckedSwitchExample to SwitchStory - OnContrast uses lighter thumb color and textOnDark for better contrast on dark backgrounds Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

- Create BpkNavigationTabGroupItemAlignment enum with Horizontal and Vertical options - Add itemAlignment parameter to control layout direction (defaults to Horizontal) - Add tabBackgroundColor parameter to customize tab background - Add tabWidth and tabHeight parameters for custom tab sizing - Update BpkNavigationTabGroupImpl to use LazyRow for horizontal and LazyColumn for vertical - Update BpkNavigationTab to accept and apply custom colors and sizing - Add NavigationTabGroupVerticalStory with vertical alignment matching Figma design - Vertical story uses 4 tabs (Flights, Hotels, Cars, Packages) on surfaceContrast background Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

… below - Add isVertical parameter to BpkNavigationTabImpl - Pass itemAlignment through NavigationTabItem to BpkNavigationTab - Implement Column layout for vertical alignment with icon centered on top - Text positioned below icon with proper spacing using BpkSpacing.Sm - Use consistent padding (BpkSpacing.Md) for vertical layout - Maintain horizontal layout behavior when isVertical is false - Center alignment for both icon and text in vertical mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

- Remove custom backgroundColor, width, height parameters from BpkNavigationTab - Simplify BpkNavigationTab to accept only isVertical flag for layout control - Update BpkNavigationTabGroupImpl to pass isVertical flag instead of individual params - Use heightIn/widthIn for flexible sizing in vertical layout (56dp min height, 88dp min width) - Adjust vertical padding and horizontal padding for vertical tabs - Set icon top padding to 1.dp for tighter spacing between icon and text - Maintain consistent styling and spacing across both vertical and horizontal layouts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

- Remove unused tabBackgroundColor, tabWidth, tabHeight from BpkNavigationTabGroup - Update BpkNavigationTabGroupImpl to pass only itemAlignment flag - Simplify NavigationTabItem function signature - Update NavigationTabGroupVerticalStory to use standard configuration - Cleanup parameter passing in both Horizontal and Vertical branches Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-authored-by: Claude <noreply@anthropic.com>

skyscanner-backpack-bot · 2026-03-09T18:25:11Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 51b24ef

- Update androidPlugin from 8.13.2 to 9.0.1 - Update lint and androidSdkCommon to 32.0.1 (formula: X+23 for AGP version X) - Add android.builtInKotlin=true to gradle.properties (required for AGP 9.0) - Add android.newDsl=false to gradle.properties (temporary compatibility flag) - Update extension imports to AGP 9.0 DSL: ApplicationExtension, LibraryExtension - Remove explicit org.jetbrains.kotlin.android plugin (handled by built-in Kotlin) - Update ProGuard config to use proguard-android-optimize.txt (R8 requirement) - Update managedDevices API to use localDevices (AGP 9.0 change) - Add targetSdk to application defaultConfig Tested with: ./gradlew assembleOssDebug -x detekt ✅ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

skyscanner-backpack-bot · 2026-03-09T20:52:54Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against f0f03a6

- Make rememberFixedTopAppBarState() public with initialStatus parameter to control expanded/collapsed state - Support both scrollable (via rememberTopAppBarState) and non-scrollable (via rememberFixedTopAppBarState) behaviors - State type determines scroll behavior - no need for additional parameters - Add NonScrollableNavBarStory to demonstrate non-scrollable nav bar variants Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

skyscanner-backpack-bot · 2026-03-10T12:12:46Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against afc3cea

- Add dynamic border width to SearchInputSummary (2.dp when focused, 1.dp otherwise) - Make border transparent for ReadOnly state with isFocused=false - Update BpkTopNavBarTest to use new TopNavBarState parameter for helper functions - Change rememberFixedTopAppBarState default to Collapsed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

skyscanner-backpack-bot · 2026-03-10T17:51:54Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 196a4f7

- Change BpkModal default navBarState from scrollable to fixed (rememberFixedTopAppBarState) - Add import for rememberFixedTopAppBarState - Modal navigation bar now defaults to non-scrollable behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

skyscanner-backpack-bot · 2026-03-10T18:07:43Z

	Warnings
⚠️	One or more component files were updated, but the docs screenshots weren't updated. If the changes are visual or it is a new component please regenerate the screenshots via `./gradlew recordScreenshots`.
⚠️	One or more component files were updated, but `README.md` wasn't updated. If your change contains API changes/additions or a new component please update the relevant component README.
⚠️	One or more package files were created, but `BpkComposeComponentUsageDetector.kt` wasn't updated. If your component is an equivalent of a core component please add it to the detector.

Generated by 🚫 Danger Kotlin against 20f6bec

Copilot AI review requested due to automatic review settings February 24, 2026 11:18

skyscanner-backpack-bot Bot added the ai: copilot used to indicate involvement of copilot in writing code in this PR label Feb 24, 2026

Copilot started reviewing on behalf of peterliu (peterInTown) February 24, 2026 11:19 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

peterliu (peterInTown) changed the title ~~DON 2543 search control GC PoC~~ [DO-NOT-MERGE] search control GC PoC Feb 26, 2026

peterliu (peterInTown) added the DON'T MERGE label Feb 26, 2026

peterliu (peterInTown) and others added 11 commits March 9, 2026 18:12

Force commit

08eac46

Co-authored-by: Copilot <Copilot@github.com>

Force commit

f12b50c

Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Force commit

1f542c0

edit swap button theme

7563bfa

finish bpkswitch implmentation

0fa2b4e

Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

add bpkdivider

57bc7db

Co-authored-by: Claude <noreply@anthropic.com>

Updates to search input summary and horizontal nav

263f6af

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Update SwitchStory and BpkSwitch refinements

ae420b0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

peterliu (peterInTown) and others added 8 commits March 9, 2026 18:12

Updates to segmented control implementation

9f8514a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Final updates to navigation tab group implementation

16ffd4e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Updates to swap button implementation

f3b7a27

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Updates to segmented control and switch implementations

2a7084d

Co-authored-by: Claude <noreply@anthropic.com>

Updates to segmented control and modal implementations

51b24ef

Co-authored-by: Claude <noreply@anthropic.com>

peterliu (peterInTown) force-pushed the DON-2543-search-control-GC-PoC branch from 41de577 to 51b24ef Compare March 9, 2026 18:22

peterliu (peterInTown) and others added 2 commits March 10, 2026 12:03

Updates to modal implementation

afc3cea

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>

Lokmane Krizou (LokmaneKrizou) closed this Mar 13, 2026

		// BpkIcon.InformationCircle would be used here when the icon extensions are properly exposed
		// For now, here's the API usage example:

	// BpkIcon.InformationCircle would be used here when the icon extensions are properly exposed
	// For now, here's the API usage example:
	// Example of a switch with an info icon.

Uh oh!

Conversation

peterliu (peterInTown) commented Feb 24, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Feb 26, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 3, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 3, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 5, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 6, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 9, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 9, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 10, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 10, 2026

Uh oh!

skyscanner-backpack-bot Bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!