Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOM-2045: Revert @typescript-eslint/eslint-plugin & @typescript-eslint/parser v8 back to v7 #807

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

jronald01
Copy link
Contributor

@jronald01 jronald01 commented Feb 7, 2025

https://skyscanner.atlassian.net/browse/LOOM-2045

https://skyscanner.slack.com/archives/C01B5E264RM/p1738921081606849

This update resulted in many false positives for the @typescript-eslint/array-type rule.

The same errors do not show up in the typescript-eslint playground, but that playground uses eslint v9 while we still use v8: https://typescript-eslint.io/play

Reverting until it can be debugged further.

const CABIN_CLASS: Array<[string, string]> = [
  [ECONOMY, ECONOMY_PROTO],
  [PREMIUM_ECONOMY, PREMIUM_ECONOMY_PROTO],
  [BUSINESS, BUSINESS_PROTO],
  [FIRST, FIRST_PROTO],
];
Array type using 'Array<any>' is forbidden for simple types. Use 'any[]' instead  @typescript-eslint/array-type

@jronald01 jronald01 added the major label for major changes label Feb 7, 2025
@dominicfraser dominicfraser changed the title Temp revert eslint 8 back to 7 Revert @typescript-eslint/eslint-plugin & @typescript-eslint/parser v8 back to v7 Feb 7, 2025
dominicfraser
dominicfraser previously approved these changes Feb 7, 2025
olliecurtis
olliecurtis previously approved these changes Feb 7, 2025
@jronald01 jronald01 dismissed stale reviews from olliecurtis and dominicfraser via 30feeb5 February 7, 2025 15:00
@dominicfraser dominicfraser changed the title Revert @typescript-eslint/eslint-plugin & @typescript-eslint/parser v8 back to v7 LOOM-2045: Revert @typescript-eslint/eslint-plugin & @typescript-eslint/parser v8 back to v7 Feb 7, 2025
@jronald01 jronald01 merged commit 8a4e113 into main Feb 7, 2025
4 checks passed
@jronald01 jronald01 deleted the temp_revert-eslint_8-to-7 branch February 7, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major label for major changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants