Added explicit TX port and mask selection on write operation. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case as follows: two instances of NeoSWSerial are engaged. The first works in "listen-only" mode, while the second uses request-reply operation. After calling .listen() on first instance, the second instance does not transmit any data. The problem is that txPort and txBitMask are static variables shared across instances, and in write() function they are not assigned and used from previous call to another port instance. So transmission happen to wrong port. May be the cause of issue SlashDevin#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case as follows: two instances of NeoSWSerial are engaged. The first works in "listen-only" mode, while the second uses request-reply operation. After calling .listen() on first instance, the second instance does not transmit any data.
The problem is that txPort and txBitMask are static variables shared across instances, and in write() function they are not assigned and used from previous call to another port instance. So transmission happen to wrong port.
May be the cause of issue #33