-
Notifications
You must be signed in to change notification settings - Fork 254
Add SlicerOpenLIFU #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.8
Are you sure you want to change the base?
Add SlicerOpenLIFU #2162
Conversation
Thanks for your work on this and interest in contributing. We saw that the license for the code is AGPL, which we interpret as a "non-permissive" license, since it may require people to change the license on other code it's mixed with. So from a Slicer point of view, that would make this a "tier 1" extension. In the future we plan not to display tier 1 extensions by default. I'd encourage you to try revisiting the license in order to collaborate more closely with the rest of the 3D Slicer community. There are many points of possible mutual benefit with projects like NousNav and SlicerTMS, but those collaborations won't be possible if you stick to the AGPL license. Please consider Apache 2.0, BSD, the Slicer License, or another option that would allow collaboration. Also, just a comment on the readme: it would be good to include a definition of LIFU and also links to your company's website to make it easier for people to quickly understand what the project is about. |
The license is a fixed choice by Openwater in this case and not likely to change. We could include a copyleft warning for anyone who tries to mix the extension into their own work. It would be convenient
Good idea. @arhowe00 here is some introductory text we could add:
This link to early access systems may be appropriate to include for now: https://www.openwater.health/early-access-systems |
Made these changes (including fixing the link) and posting a PR to SlicerOpenLIFU. |
Changes have been pushed to main @pieper |
In medical image computing, permissive (MIT, Apache, BSD) licenses are the standard for open-source tools, probably because restrictive licenses practically prevent translating prototypes into clinical use. A restrictive license is acceptable in the Extensions Index, but to increase the impact of this extension and encourage community engagement, a permissive license would be a much better fit. Would you be able to start a discussion with your funder about their open-source strategy and goals? They may find that the extreme AGPL license is not the best choice to achieve those goals. We would be happy to provide more details or participate in meetings if that helps. |
The choice of AGPL seems to be quite deliberate, but it doesn't hurt to ask and I'm not actually sure it's non-negotiable or that nothing has changed since that choice was made. We can reach out and get back to you @lassoan and @pieper. Thanks! |
New extension
Tier 1
Any extension that is listed in the Extensions Catalog must fulfill these requirements.
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used).About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)Tier 3
Community-supported extensions.
Tier 5
Critically important extensions, supported by Slicer core developers. New Slicer Stable Release is released only if all Tier 5 extension packages are successfully created on all supported platforms.
An issue was opened regarding the variable set below in the root
CMakeLists.txt
:where
Screenshots
is supposed to be all lowercase as in the extension repository SlicerOpenLIFU.