Skip to content

COMP: Fix -Winconsistent-missing-override warnings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

COMP: Fix -Winconsistent-missing-override warnings #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions AutoPortPlacement/Logic/vtkSlicerAutoPortPlacementLogic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class VTK_SLICER_AUTOPORTPLACEMENT_MODULE_LOGIC_EXPORT vtkSlicerAutoPortPlacemen

static vtkSlicerAutoPortPlacementLogic *New();
vtkTypeMacro(vtkSlicerAutoPortPlacementLogic, vtkSlicerModuleLogic);
void PrintSelf(ostream& os, vtkIndent indent);
void PrintSelf(ostream& os, vtkIndent indent) override;

// For setting the rotation values of each joint in the robot's arm
void SetPassiveLeftJoint(unsigned jointIdx, double value);
Expand Down Expand Up @@ -94,14 +94,14 @@ class VTK_SLICER_AUTOPORTPLACEMENT_MODULE_LOGIC_EXPORT vtkSlicerAutoPortPlacemen

protected:
vtkSlicerAutoPortPlacementLogic();
virtual ~vtkSlicerAutoPortPlacementLogic();
~vtkSlicerAutoPortPlacementLogic() override;

virtual void SetMRMLSceneInternal(vtkMRMLScene* newScene);
void SetMRMLSceneInternal(vtkMRMLScene* newScene) override;
/// Register MRML Node classes to Scene. Gets called automatically when the MRMLScene is attached to this logic class.
virtual void RegisterNodes();
virtual void UpdateFromMRMLScene();
virtual void OnMRMLSceneNodeAdded(vtkMRMLNode* node);
virtual void OnMRMLSceneNodeRemoved(vtkMRMLNode* node);
void RegisterNodes() override;
void UpdateFromMRMLScene() override;
void OnMRMLSceneNodeAdded(vtkMRMLNode* node) override;
void OnMRMLSceneNodeRemoved(vtkMRMLNode* node) override;
private:

vtkSlicerAutoPortPlacementLogic(const vtkSlicerAutoPortPlacementLogic&); // Not implemented
Expand Down
20 changes: 10 additions & 10 deletions AutoPortPlacement/qSlicerAutoPortPlacementModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,29 +38,29 @@ qSlicerAutoPortPlacementModule

typedef qSlicerLoadableModule Superclass;
explicit qSlicerAutoPortPlacementModule(QObject *parent=0);
virtual ~qSlicerAutoPortPlacementModule();
~qSlicerAutoPortPlacementModule() override;

qSlicerGetTitleMacro(QTMODULE_TITLE);

virtual QString helpText()const;
virtual QString acknowledgementText()const;
virtual QStringList contributors()const;
QString helpText()const override;
QString acknowledgementText()const override;
QStringList contributors()const override;

virtual QIcon icon()const;
QIcon icon()const override;

virtual QStringList categories()const;
virtual QStringList dependencies() const;
QStringList categories()const override;
QStringList dependencies() const override;

protected:

/// Initialize the module. Register the volumes reader/writer
virtual void setup();
void setup() override;

/// Create and return the widget representation associated to this module
virtual qSlicerAbstractModuleRepresentation * createWidgetRepresentation();
qSlicerAbstractModuleRepresentation * createWidgetRepresentation() override;

/// Create and return the logic associated to this module
virtual vtkMRMLAbstractLogic* createLogic();
vtkMRMLAbstractLogic* createLogic() override;

protected:
QScopedPointer<qSlicerAutoPortPlacementModulePrivate> d_ptr;
Expand Down
4 changes: 2 additions & 2 deletions AutoPortPlacement/qSlicerAutoPortPlacementModuleWidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Q_SLICER_QTMODULES_AUTOPORTPLACEMENT_EXPORT qSlicerAutoPortPlacementModule

typedef qSlicerAbstractModuleWidget Superclass;
qSlicerAutoPortPlacementModuleWidget(QWidget *parent=0);
virtual ~qSlicerAutoPortPlacementModuleWidget();
~qSlicerAutoPortPlacementModuleWidget() override;

// If robot configuration is changed programmatically, have sliders
// reflect change
Expand All @@ -55,7 +55,7 @@ public slots:
protected:
QScopedPointer<qSlicerAutoPortPlacementModuleWidgetPrivate> d_ptr;

virtual void setup();
void setup() override;

private:
Q_DECLARE_PRIVATE(qSlicerAutoPortPlacementModuleWidget);
Expand Down