Make Slimefun blocks unable to be replaced#93
Merged
TheBusyBiscuit merged 2 commits intoSlimefun:masterfrom Jul 20, 2021
Merged
Make Slimefun blocks unable to be replaced#93TheBusyBiscuit merged 2 commits intoSlimefun:masterfrom
TheBusyBiscuit merged 2 commits intoSlimefun:masterfrom
Conversation
TheBusyBiscuit
requested changes
Jul 18, 2021
src/main/java/io/github/thebusybiscuit/sensibletoolbox/SensibleToolboxPlugin.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Multibuilder, in SWAP mode, could swap the material of Slimefun blocks. This allows the duping of blocks on a 1 by 1 basis. In the example provided on the Slimefun Discord, the Powered Bedrock block from Infinity Expansion constantly set's it's material back which allowed for a very fast and powerful dupe.
Changes
Given the potential issues, and that all STB blocks are also exempt from swapping, I have added a Blockstorage check to the canReplace() method should Simefun be present.
Added a isSlimefunEnabled variable and a getter to SensibleToolboxPlugin.java
Related Issues
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values