Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Device (Zigbee Lock) Nimly Door Lock #1856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lelandblue
Copy link
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR is adding a fingerprint only for a device seeking WWST Submission. Further device testing is planned.

The device is a Zigbee Lock.

Summary of Completed Tests

@greens
Copy link
Contributor

greens commented Jan 9, 2025

tests are failing because this is based on a branch prior to #1858 , but should be fine now if rebased

Copy link

github-actions bot commented Jan 10, 2025

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 11c4c03

Copy link

Copy link

Test Results

   64 files    404 suites   0s ⏱️
2 009 tests 2 009 ✅ 0 💤 0 ❌
3 471 runs  3 471 ✅ 0 💤 0 ❌

Results for commit 11c4c03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants