Matter 1.4 Driver Release #1870

nickolas-deboom · 2025-01-13T20:09:41Z

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR contains changes to support new device types introduced by the Matter 1.4 specification. These device types include the following:

Mounted On/Off Control
Mounted Dimmable Load Control
Water Heater
Solar Power
Battery Storage
Heat Pump

Summary of Completed Tests

github-actions · 2025-01-13T20:11:16Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/3X21QvpJmR2R

github-actions · 2025-01-13T20:11:41Z

Test Results

65 files + 1 412 suites +6 0s ⏱️ ±0s
2 037 tests +24 2 037 ✅ +24 0 💤 ±0 0 ❌ ±0
3 529 runs +40 3 529 ✅ +40 0 💤 ±0 0 ❌ ±0

Results for commit 6f0a524. ± Comparison against base commit 7171fd3.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-13T20:11:42Z

matter-evse_coverage.xml

File	Coverage
All files	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/init.lua	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/embedded_cluster_utils.lua	`82%`	❌

matter-hrap_coverage.xml

File	Coverage
All files	`100%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/init.lua	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/embedded_cluster_utils.lua	`82%`	❌

matter-switch_coverage.xml

File	Coverage
All files	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/init.lua	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/embedded_cluster_utils.lua	`82%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua	`38%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua	`91%`	✅

matter-thermostat_coverage.xml

File	Coverage
All files	`82%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/init.lua	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/embedded_cluster_utils.lua	`82%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua	`38%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	`83%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	`46%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 6f0a524

This initial commit adds support for the mounted on/off control and mounted dimmable load control device types introduced by the matter 1.4 spec.

Add initial driver support for HRAP devices

github-actions · 2025-01-23T19:01:01Z

Duplicate profile check: Passed - no duplicate profiles detected.

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/init.lua

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/server/attributes/init.lua

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/types/init.lua

drivers/SmartThings/matter-hrap/src/WiFiNetworkManagement/init.lua

drivers/SmartThings/matter-hrap/src/init.lua

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/init.lua

drivers/SmartThings/matter-hrap/src/init.lua

drivers/SmartThings/matter-hrap/src/WiFiNetworkManagement/init.lua

drivers/SmartThings/matter-switch/src/init.lua

drivers/SmartThings/matter-hrap/src/embedded-cluster-utils.lua

nickolas-deboom · 2025-01-23T21:30:51Z

I left a few comments but everything else in the HRAP driver looks good to me! I can't remember but was there a file we've updated in the past to prevent github from checking test coverage of the embedded lua libs files? We could update that as part of this PR as well (I just can't remember where it is)

nickolas-deboom · 2025-01-23T21:33:30Z

I get an error when trying to package the hrap driver locally:

» smartthings edge:drivers:package                                                                                                                                nickloasdeboom@MN-NDEBOOM-L
    AxiosError: Request failed with status code 422: {"requestId":"1610617032588185407","error":{"code":"ConstraintViolationError","message":"Invalid device profile specification for 
    eb1b3ce7-a434-4cd9-8fab-e5289b628b35","details":[{"code":"NotValidValue","target":"main.capabilities.routerName","message":"Capability does not exist: routerName version 
    1","details":[]},{"code":"NotValidValue","target":"main.capabilities.threadVersion","message":"Capability does not exist: threadVersion version 
    1","details":[]},{"code":"NotValidValue","target":"main.capabilities.routerState","message":"Capability does not exist: routerState version 1","details":[]}]}}
    Code: ERR_BAD_REQUEST

Is this happening due to the embedded capability definitions?

The mounted device types will already join to the correct fingerprint and so do not require the logic added for them in initialize_switch to select the correct profile.

Signed-off-by: s-gatti <[email protected]> Co-authored-by: Hunsup Jung <[email protected]>

hcarter-775 · 2025-02-03T17:34:48Z

drivers/SmartThings/matter-thermostat/src/init.lua

+local function delete_reporting_timer(device)
+  local reporting_poll_timer = device:get_field(RECURRING_REPORT_TIMER)
+  if reporting_poll_timer ~= nil then
+    device.thread:cancel_timer(reporting_poll_timer)
+    device:set_field(RECURRING_REPORT_TIMER, nil)
+  end
+end
+
+local function remove_timers(device)
+  delete_reporting_timer(device)
+  local poll_timer = device:get_field(RECURRING_POLL_TIMER)
+  if poll_timer ~= nil then
+    device.thread:cancel_timer(poll_timer)
+    device:set_field(RECURRING_POLL_TIMER, nil)
+  end
+end


This seems like unnecessary breakdown of functionality to me. I would suggest:

Suggested change

local function delete_reporting_timer(device)

local reporting_poll_timer = device:get_field(RECURRING_REPORT_TIMER)

if reporting_poll_timer ~= nil then

device.thread:cancel_timer(reporting_poll_timer)

device:set_field(RECURRING_REPORT_TIMER, nil)

end

end

local function remove_timers(device)

delete_reporting_timer(device)

local poll_timer = device:get_field(RECURRING_POLL_TIMER)

if poll_timer ~= nil then

device.thread:cancel_timer(poll_timer)

device:set_field(RECURRING_POLL_TIMER, nil)

end

end

local function remove_timers(device)

-- remove report timer

local reporting_poll_timer = device:get_field(RECURRING_REPORT_TIMER)

if reporting_poll_timer ~= nil then

device.thread:cancel_timer(reporting_poll_timer)

device:set_field(RECURRING_REPORT_TIMER, nil)

end

-- remove poll timer

local poll_timer = device:get_field(RECURRING_POLL_TIMER)

if poll_timer ~= nil then

device.thread:cancel_timer(poll_timer)

device:set_field(RECURRING_POLL_TIMER, nil)

end

end

hcarter-775 · 2025-02-03T17:36:41Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    local val = find_default_endpoint(device, clusters.Thermostat.ID)
+    return val


why was this changed?

hcarter-775 · 2025-02-03T19:55:57Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    local previousTotalConsumptionWh = device:get_latest_state("main", capabilities.powerConsumptionReport
+      .ID,


Suggested change

local previousTotalConsumptionWh = device:get_latest_state("main", capabilities.powerConsumptionReport

.ID,

local previousTotalConsumptionWh = device:get_latest_state("main", capabilities.powerConsumptionReport.ID,

nickolas-deboom · 2025-02-03T20:36:19Z

drivers/SmartThings/matter-evse/src/init.lua

+    clusters.ElectricalEnergyMeasurement.ID,
+    {feature_bitmap = clusters.ElectricalEnergyMeasurement.types.Feature.CUMULATIVE_ENERGY })
+  if cumul_eps and #cumul_eps > 0 then
+    local read_req = clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyImported:read(device)


Should there be a loop here similar to below in case there are multiple endpoints containing the ElectricalEnergyMeasurement cluster? Or is it not expected to have multiple endpoints?

Suggested change

local read_req = clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyImported:read(device)

local read_req = clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyImported:read(device)

for i, ep in ipairs(cumul_eps) do

if i > 1 then

read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, cumul_eps[i]))

end

end

hcarter-775 · 2025-02-03T20:41:22Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    if #electrical_sensor_eps > 0 then
+      profile_name = "water-heater-power-energy-powerConsumption"
+    end
+  elseif #thermostat_eps > 0 and device_type ~= HEAT_PUMP_DEVICE_TYPE_ID then


I think we should keep this simple and implement it as:

Suggested change

elseif #thermostat_eps > 0 and device_type ~= HEAT_PUMP_DEVICE_TYPE_ID then

elseif device_type == HEAT_PUMP_DEVICE_TYPE_ID then

profile_name = "heat-pump"

elseif #thermostat_eps > 0 then

This is more extensible and keeps the original logical flow. And to continue a comment I left earlier, rather than heat-pump it should be

profile_name = "heat-pump-2-thermostat"

in the suggestion I made.

hcarter-775 · 2025-02-03T20:46:38Z

drivers/SmartThings/matter-thermostat/src/init.lua

+  local thermostat_eps = get_endpoints_for_dt(device, THERMOSTAT_DEVICE_TYPE_ID)
+  if #heat_pump_eps > 0 then
+    local component_to_endpoint_map = {
+      ["thermostatOne"] = thermostat_eps[1],
+      ["thermostatTwo"] = thermostat_eps[2],
+    }
+    device:set_field(COMPONENT_TO_ENDPOINT_MAP, component_to_endpoint_map, {persist = true})
+  end


Suggested change

local thermostat_eps = get_endpoints_for_dt(device, THERMOSTAT_DEVICE_TYPE_ID)

if #heat_pump_eps > 0 then

local component_to_endpoint_map = {

["thermostatOne"] = thermostat_eps[1],

["thermostatTwo"] = thermostat_eps[2],

}

device:set_field(COMPONENT_TO_ENDPOINT_MAP, component_to_endpoint_map, {persist = true})

end

if #heat_pump_eps > 0 then

local thermostat_eps = get_endpoints_for_dt(device, THERMOSTAT_DEVICE_TYPE_ID)

local component_to_endpoint_map = {

["thermostatOne"] = thermostat_eps[1],

["thermostatTwo"] = thermostat_eps[2],

}

device:set_field(COMPONENT_TO_ENDPOINT_MAP, component_to_endpoint_map, {persist = true})

end

Though this is pretty un-extendable as-is. I do think we should extend this logic to permit 1, 2, or more thermostats, even if we only have a profile to support the 2 case for now.

hcarter-775 · 2025-02-03T21:24:09Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    if version.api < 11 then
+      clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyImported:augment_type(ib.data)
+    end


for my understanding, what is this logic doing?

hcarter-775 · 2025-02-03T21:30:00Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    if tbl_contains(cumul_eps, endpoint_id) then
+      -- Since cluster at this endpoint supports both CUME & PERE features, we will prefer
+      -- cumulative_energy_imported_handler to handle the energy report for this endpoint.
+      return
+    end


let's move this top the top of the function handler. There's no need to do any further logic if this is true.

nickolas-deboom · 2025-02-03T21:34:07Z

drivers/SmartThings/matter-evse/src/init.lua

-  }
-  log.debug("component_to_endpoint_map " .. utils.stringify_table(component_to_endpoint_map))
-  device:set_field(COMPONENT_TO_ENDPOINT_MAP, component_to_endpoint_map, { persist = true })
+  local evse_eps = get_endpoints_for_dt(device, EVSE_DEVICE_TYPE_ID)


Suggested change

local evse_eps = get_endpoints_for_dt(device, EVSE_DEVICE_TYPE_ID)

local evse_eps = get_endpoints_for_dt(device, EVSE_DEVICE_TYPE_ID) or {}

To prevent an error on the next line in the case that get_endpoints_for_dt returns nil

nickolas-deboom · 2025-02-03T21:44:59Z

drivers/SmartThings/matter-evse/src/init.lua

+        [clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyImported.ID] = cumulative_energy_handler(TOTAL_CUMULATIVE_ENERGY_IMPORTED),
+        [clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyImported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_IMPORTED),
+        [clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported.ID] = cumulative_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),
+        [clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyImported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),


Suggested change

[clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyImported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),

[clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyExported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),

I think this was meant to be PeriodicEnergyExported

hcarter-775 · 2025-02-03T22:00:42Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    local energy_imported_Wh = utils.round(energy_imported_mWh / 1000)
+    local cumulative_energy_imported = device:get_field(TOTAL_CUMULATIVE_ENERGY_IMPORTED_MAP) or {}
+    cumulative_energy_imported[endpoint_id] = cumulative_energy_imported[endpoint_id] + energy_imported_Wh
+    device:set_field(TOTAL_CUMULATIVE_ENERGY_IMPORTED_MAP, cumulative_energy_imported, { persist = true })


why are we adding this map handling? Are we expecting devices that support energy control on multiple endpoints? As far as I see, neither of the two new thermostat device types support this.

hcarter-775 · 2025-02-03T22:09:37Z

drivers/SmartThings/matter-thermostat/src/init.lua

+    local cumulative_energy_imported_mWh = ib.data.elements.energy.value
+    local cumulative_energy_imported_Wh = utils.round(cumulative_energy_imported_mWh / 1000)


Suggested change

local cumulative_energy_imported_mWh = ib.data.elements.energy.value

local cumulative_energy_imported_Wh = utils.round(cumulative_energy_imported_mWh / 1000)

local cumulative_energy_imported_Wh = utils.round( ib.data.elements.energy.value / 1000) -- convert mWh to Wh

same thing for the periodic energy handler

hcarter-775 · 2025-02-03T22:13:39Z

drivers/SmartThings/matter-thermostat/src/init.lua

+  for i, mode in ipairs(supportWaterHeaterModes) do
+    if i - 1 == currentMode then


Is this numerical ordering of the modes an assumption we can safely make?

hcarter-775 · 2025-02-03T22:14:51Z

drivers/SmartThings/matter-thermostat/src/test/test_matter_heat_pump.lua

+)
+
+test.register_message_test(
+  "Heating setpoint reports from child thermostat devices should emit correct events to the corret endpoint",


Suggested change

"Heating setpoint reports from child thermostat devices should emit correct events to the corret endpoint",

"Heating setpoint reports from component thermostat devices should emit correct events to the corret endpoint",

hcarter-775 · 2025-02-03T22:15:12Z

drivers/SmartThings/matter-thermostat/src/test/test_matter_heat_pump.lua

+)
+
+test.register_message_test(
+  "Cooling setpoint reports reports from child thermostat devices should emit correct events to the corret endpoint",


Suggested change

"Cooling setpoint reports reports from child thermostat devices should emit correct events to the corret endpoint",

"Cooling setpoint reports reports from component thermostat devices should emit correct events to the correct endpoint",

drivers/SmartThings/matter-evse/src/init.lua

hcarter-775 · 2025-02-04T00:13:09Z

drivers/SmartThings/matter-evse/fingerprints.yml

@@ -5,3 +5,13 @@ matterGeneric:
      - id: 0x0510
      - id: 0x050C
    deviceProfileName: evse
+  - id: "matter/solar-power"


I think we should change the name of this driver from matter-evse to matter-energy.

I think so.

hcarter-775 · 2025-02-04T00:15:22Z

drivers/SmartThings/matter-evse/src/init.lua

@@ -115,6 +134,16 @@ local function tbl_contains(array, value)
  return false
 end

+local get_total = function(map)
+  if map ~= nil and type(map) == "table" then


I think we should leave a debug message for the case where type(map) == "table"

hcarter-775 · 2025-02-04T00:17:09Z

drivers/SmartThings/matter-evse/src/init.lua

      if i > 1 then
-        read_req:merge(clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyImported:read(device, ep))
+      read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, eps_to_read[i]))


Suggested change

read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, eps_to_read[i]))

read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, ep)

hcarter-775 · 2025-02-04T00:28:10Z

drivers/SmartThings/matter-evse/src/init.lua

+  -- Consider only Solar Power / Battery Storage devices and sum up in case there are multiple endpoints.
+  local battery_storage_eps = get_endpoints_for_dt(device, SOLAR_POWER_DEVICE_TYPE_ID)
+  local solar_power_eps = get_endpoints_for_dt(device, BATTERY_STORAGE_DEVICE_TYPE_ID)
+  if (tbl_contains(solar_power_eps, ib.endpoint_id) or tbl_contains(battery_storage_eps, ib.endpoint_id)) and ib.data.value then


This logic doesn't seem necessary, since we wouldn't be subscribing to this attribute in other device types in the first place.

hcarter-775 · 2025-02-04T00:29:30Z

drivers/SmartThings/matter-evse/src/init.lua

+
+    active_power_map[endpoint_id] = watt_value
+    local total_active_power = get_total(active_power_map)
+    device:set_field(TOTAL_ACTIVE_POWER, active_power_map)


what devices do we expect to support multiple active power measurements?

nickolas-deboom · 2025-02-04T15:46:09Z

drivers/SmartThings/matter-evse/src/init.lua

+  local previousTotalConsumptionWh = device:get_latest_state(comp, capabilities.powerConsumptionReport
+  .ID,


Suggested change

local previousTotalConsumptionWh = device:get_latest_state(comp, capabilities.powerConsumptionReport

.ID,

local previousTotalConsumptionWh = device:get_latest_state(comp, capabilities.powerConsumptionReport.ID,

drivers/SmartThings/matter-hrap/src/init.lua

nickolas-deboom · 2025-02-04T20:04:38Z

drivers/SmartThings/matter-thermostat/src/init.lua

+--   2. if the received setpoint command value is in range 86 ~ 176, it is inferred as *F
+local WATER_HEATER_MAX_TEMP_IN_C = 80.0
+local WATER_HEATER_MIN_TEMP_IN_C = 30.0
+


Should there also be a temperature range defined for Heat Pump? What would the expected range be for that device type? Currently it would use the 5-40 deg C range for thermostats

No, a heat pump can just use the thermostat range, since it will be attached to regular thermostats.

nickolas-deboom · 2025-02-06T17:09:51Z

drivers/SmartThings/matter-thermostat/src/init.lua

+  end
+end
+
+local function periodic_energy_imported_handler(driver, device, ib, response)


Could you create test case(s) that exercise this function?

nickolas-deboom · 2025-02-06T17:10:52Z

drivers/SmartThings/matter-thermostat/src/init.lua

+  device:emit_event_for_endpoint(ib.endpoint_id, event)
+end
+
+local function water_heater_mode_handler(driver, device, ib, response)


Could you also create a test case for the water heater mode handler?

hcarter-775 · 2025-02-13T19:08:17Z

drivers/SmartThings/matter-evse/profiles/solar-power.yml

+  - name: SolarPanel
+- id: exportedEnergy
+  capabilities:
+  - id: powerConsumptionReport


what is the reasoning for displaying the power Consumption report for this?

powerConsumptionReport is the capability used for Energy service. In the long run, we wait for this information to be reported to the Energy service.

hcarter-775 · 2025-02-13T19:42:49Z

drivers/SmartThings/matter-thermostat/profiles/heat-pump.yml

+  capabilities:
+  - id: thermostatMode
+    version: 1
+  - id: relativeHumidityMeasurement


I don't think this should be a required trait. I think we should separate humidity into a separate profile that uses a -humidity for each thermostat in the profile name.

Okay I will modify it

nickolas-deboom added the workinprogress label Jan 13, 2025

nickolas-deboom requested review from ctowns, z-michel, HunsupJung and hcarter-775 January 13, 2025 20:09

nickolas-deboom force-pushed the matter-v1.4-release branch from 7cd7eea to 07a1493 Compare January 15, 2025 19:53

Matter 1.4 Driver Release

d9cb0ed

This initial commit adds support for the mounted on/off control and mounted dimmable load control device types introduced by the matter 1.4 spec.

nickolas-deboom force-pushed the matter-v1.4-release branch from 07a1493 to d9cb0ed Compare January 15, 2025 20:11

hcarter-775 and others added 4 commits January 22, 2025 16:34

add initial hrap driver

6a4d656

fixup to pass luachecks

b4a1b01

Merge branch 'main' into matter-v1.4-release

8cae4df

Merge pull request #1890 from SmartThingsCommunity/matter-hrap

31e5755

Add initial driver support for HRAP devices

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/server/attributes/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/types/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/WiFiNetworkManagement/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/init.lua Outdated Show resolved Hide resolved

nickolas-deboom commented Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/ThreadBorderRouterManagement/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/init.lua Outdated Show resolved Hide resolved

nickolas-deboom commented Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/WiFiNetworkManagement/init.lua Outdated Show resolved Hide resolved

ctowns reviewed Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-switch/src/init.lua Outdated Show resolved Hide resolved

nickolas-deboom commented Jan 23, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/embedded-cluster-utils.lua Outdated Show resolved Hide resolved

nickolas-deboom and others added 2 commits January 23, 2025 15:39

Remove logic added for mounted device types

83f80b0

The mounted device types will already join to the correct fingerprint and so do not require the logic added for them in initialize_switch to select the correct profile.

Support Battery Storage device type and Solar Power device type (#1900)

7b87330

Signed-off-by: s-gatti <[email protected]> Co-authored-by: Hunsup Jung <[email protected]>

hcarter-775 reviewed Feb 3, 2025

View reviewed changes

nickolas-deboom commented Feb 3, 2025

View reviewed changes

hcarter-775 reviewed Feb 3, 2025

View reviewed changes

nickolas-deboom commented Feb 3, 2025

View reviewed changes

hcarter-775 reviewed Feb 3, 2025

View reviewed changes

hcarter-775 reviewed Feb 4, 2025

View reviewed changes

drivers/SmartThings/matter-evse/src/init.lua Show resolved Hide resolved

hcarter-775 reviewed Feb 4, 2025

View reviewed changes

nickolas-deboom commented Feb 4, 2025

View reviewed changes

drivers/SmartThings/matter-hrap/src/init.lua Outdated Show resolved Hide resolved

nickolas-deboom commented Feb 4, 2025

View reviewed changes

fix spacing issues in matter-hrap

08b5ed4

nickolas-deboom commented Feb 6, 2025

View reviewed changes

remove matter-hrap from the 1.4 release

05a30b2

hcarter-775 reviewed Feb 13, 2025

View reviewed changes

		local val = find_default_endpoint(device, clusters.Thermostat.ID)
		return val

		local previousTotalConsumptionWh = device:get_latest_state("main", capabilities.powerConsumptionReport
		.ID,

-  elseif #thermostat_eps > 0 and device_type ~= HEAT_PUMP_DEVICE_TYPE_ID then
+  elseif device_type == HEAT_PUMP_DEVICE_TYPE_ID then
+    profile_name = "heat-pump"
+  elseif #thermostat_eps > 0 then

	local evse_eps = get_endpoints_for_dt(device, EVSE_DEVICE_TYPE_ID)
	local evse_eps = get_endpoints_for_dt(device, EVSE_DEVICE_TYPE_ID) or {}

	[clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyImported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),
	[clusters.ElectricalEnergyMeasurement.attributes.PeriodicEnergyExported.ID] = periodic_energy_handler(TOTAL_CUMULATIVE_ENERGY_EXPORTED),

		local cumulative_energy_imported_mWh = ib.data.elements.energy.value
		local cumulative_energy_imported_Wh = utils.round(cumulative_energy_imported_mWh / 1000)

		for i, mode in ipairs(supportWaterHeaterModes) do
		if i - 1 == currentMode then

	"Heating setpoint reports from child thermostat devices should emit correct events to the corret endpoint",
	"Heating setpoint reports from component thermostat devices should emit correct events to the corret endpoint",

	"Cooling setpoint reports reports from child thermostat devices should emit correct events to the corret endpoint",
	"Cooling setpoint reports reports from component thermostat devices should emit correct events to the correct endpoint",

	read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, eps_to_read[i]))
	read_req:merge( clusters.ElectricalEnergyMeasurement.attributes.CumulativeEnergyExported:read(device, ep)

Matter 1.4 Driver Release #1870

Are you sure you want to change the base?

Matter 1.4 Driver Release #1870

Conversation

nickolas-deboom commented Jan 13, 2025 • edited by hcarter-775 Loading

Type of Change

Checklist

Description of Change

Summary of Completed Tests

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025 • edited Loading

Test Results

github-actions bot commented Jan 13, 2025 • edited Loading

github-actions bot commented Jan 23, 2025

nickolas-deboom commented Jan 23, 2025

nickolas-deboom commented Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcarter-775 Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcarter-775 Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcarter-775 Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickolas-deboom Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcarter-775 Feb 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickolas-deboom commented Jan 13, 2025 •

edited by hcarter-775

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

nickolas-deboom commented Jan 23, 2025 •

edited

Loading

hcarter-775 Feb 3, 2025 •

edited

Loading

hcarter-775 Feb 3, 2025 •

edited

Loading

hcarter-775 Feb 4, 2025 •

edited

Loading

nickolas-deboom Feb 6, 2025 •

edited

Loading

hcarter-775 Feb 13, 2025 •

edited

Loading