Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElectricalMeasurement cluster configuration #1877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kdbang
Copy link
Collaborator

@kdbang kdbang commented Jan 16, 2025

Add ElectricalMeasurement cluster configuration

  • ACPowerDivisor
  • ACPowerMultiplier
local active_power_ac_power_multiplier_configuration = {
  cluster = zcl_clusters.ElectricalMeasurement.ID,
  attribute = zcl_clusters.ElectricalMeasurement.attributes.ACPowerMultiplier.ID,
  minimum_interval = 1,
  maximum_interval = 43200,
  data_type = zcl_clusters.ElectricalMeasurement.attributes.ACPowerMultiplier.base_type,
  reportable_change = 1
}

local instantaneous_demand_configuration = {
  cluster = zcl_clusters.SimpleMetering.ID,
  attribute = zcl_clusters.SimpleMetering.attributes.InstantaneousDemand.ID,
  minimum_interval = 1,
  maximum_interval = 3600,
  data_type = zcl_clusters.SimpleMetering.attributes.InstantaneousDemand.base_type,
  reportable_change = 5
}

refer to
https://smartthings.atlassian.net/browse/CHAD-14701
https://github.ecodesamsung.com/iot-hub/scripting-engine/pull/1755

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Copy link

github-actions bot commented Jan 16, 2025

Test Results

   64 files  ±0    404 suites  ±0   0s ⏱️ ±0s
2 009 tests ±0  2 005 ✅  - 4  0 💤 ±0  4 ❌ +4 
3 471 runs  ±0  3 464 ✅  - 7  0 💤 ±0  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 48fa4cf. ± Comparison against base commit ad6cc1c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 16, 2025

zigbee-power-meter_coverage.xml

File Coverage
All files 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 76%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97%

zigbee-switch_coverage.xml

File Coverage
All files 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/shinasystems/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 76%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/init.lua 73%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/multi-switch/init.lua 87%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/wallhero/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/vimar/init.lua 70%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/aurora-relay/init.lua 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/jasco/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/ge-link-bulb/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/enbrighten-metering-dimmer/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 48fa4cf

 - ACPowerDivisor
 - ACPowerMultiplier

Signed-off-by: Keuckdo Bang <[email protected]>
@kdbang kdbang force-pushed the add_divisor_multiplier branch from 45497a6 to 48fa4cf Compare January 16, 2025 02:47
@NoahCornell
Copy link
Contributor

Hi @kdbang, it looks like this change was needed to get some tests passing in the scripting-engine repo driver tests. Just checking if we were still planning on getting this in?

@kdbang
Copy link
Collaborator Author

kdbang commented Jan 31, 2025

Hi @kdbang, it looks like this change was needed to get some tests passing in the scripting-engine repo driver tests. Just checking if we were still planning on getting this in?

@NoahCornell
yes, I think this PR needs to be merged with below PR.
https://github.ecodesamsung.com/iot-hub/scripting-engine/pull/1755

I think we should deploy zigbee-switch and zigbe-power-merter edge driver with 0.56 hub core.
I am not sure when we can deploy the edge drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants