-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature (Hub Driver) Adding profiles and fingerprints CHAD-14786 #1896
base: main
Are you sure you want to change the base?
Conversation
Duplicate profile check: Warning - duplicate profiles detected. |
Test Results 64 files 409 suites 0s ⏱️ Results for commit 54e6a9f. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 54e6a9f |
Hi, @lelandblue @nathankooistra Now we can get badge icons https://client.smartthings.com/icons/badges/cooktop/on Please proceed creating hub profiles. Thank you. |
I missed filing these in earlier so adding them, while Using "_" instead of "-"
Invitation URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -11,6 +11,14 @@ hub: | |||
deviceLabel: SmartThings Hub | |||
hardwareType: SAMSUNG_DA_REFRIGERATOR_HUB | |||
deviceProfileName: refrigerator-hub | |||
- id: "washer-dryer-hub" | |||
deviceLabel: SmartThings Hub | |||
hardwareType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, hardwaretype is defined in cloud based on https://smartthings.atlassian.net/wiki/spaces/HUBPLT/pages/26771622/Hub+Hardware+IDs.
I think it could be guessing from previous naming rules.
SAMSUNG_DA_WASHER_DRYER_HUB
SAMSUNG_DA_COOKTOP_HUB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @nathankooistra Can you please help to define above hardware types?
SAMSUNG_DA_WASHER_DRYER_HUB
SAMSUNG_DA_COOKTOP_HUB
Regarding badge icons(badge icon url), it is undergoing below ticket.
https://smartthings.atlassian.net/browse/CAPI-6509
Draft PR in support of CHAD-14786
To Do
Type of Change
Checklist
Description of Change
Adding two new profiles and two new fingerprints