Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature (Hub Driver) Adding profiles and fingerprints CHAD-14786 #1896

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lelandblue
Copy link
Contributor

@lelandblue lelandblue commented Jan 24, 2025

Draft PR in support of CHAD-14786

To Do

  • Add hardwareType: for the two new fingerprints
  • Verify the new iconURLs, in the two new profiles

Type of Change

  • WWST Certification Request
  • Bug fix
  • [ X ] New feature
  • Refactor

Checklist

  • [X ] I have performed a self-review of my code
  • [ X] I have commented my code in hard-to-understand areas
  • [X ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [ X] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding two new profiles and two new fingerprints

Copy link

github-actions bot commented Jan 24, 2025

Duplicate profile check: Warning - duplicate profiles detected.
cooktop-hub.yml == washer-dryer-hub.yml
cooktop-hub.yml == soundbar-hub.yml
cooktop-hub.yml == refrigerator-hub.yml
cooktop-hub.yml == hub-thing.yml
cooktop-hub.yml == tv-hub.yml
washer-dryer-hub.yml == soundbar-hub.yml
washer-dryer-hub.yml == refrigerator-hub.yml
washer-dryer-hub.yml == hub-thing.yml
washer-dryer-hub.yml == tv-hub.yml

Copy link

github-actions bot commented Jan 24, 2025

Test Results

   64 files    409 suites   0s ⏱️
2 033 tests 2 033 ✅ 0 💤 0 ❌
3 512 runs  3 512 ✅ 0 💤 0 ❌

Results for commit 54e6a9f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 24, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 54e6a9f

@imetjade
Copy link

Hi, @lelandblue @nathankooistra

Now we can get badge icons
(https://smartthings.atlassian.net/browse/CAPI-6509)

https://client.smartthings.com/icons/badges/cooktop/on
https://client.smartthings.com/icons/badges/washer_dryer/on

Please proceed creating hub profiles.

Thank you.

@lelandblue lelandblue requested a review from tpmanley February 14, 2025 13:16
@lelandblue lelandblue marked this pull request as ready for review February 14, 2025 13:17
@lelandblue lelandblue requested review from chrisfsmith and cbaumler and removed request for chrisfsmith February 14, 2025 13:20
I missed filing these in earlier so adding them, while Using "_" instead of "-"
Copy link

@cbaumler cbaumler requested a review from wkhenon February 14, 2025 16:50
Copy link

@imetjade imetjade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -11,6 +11,14 @@ hub:
deviceLabel: SmartThings Hub
hardwareType: SAMSUNG_DA_REFRIGERATOR_HUB
deviceProfileName: refrigerator-hub
- id: "washer-dryer-hub"
deviceLabel: SmartThings Hub
hardwareType:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, hardwaretype is defined in cloud based on https://smartthings.atlassian.net/wiki/spaces/HUBPLT/pages/26771622/Hub+Hardware+IDs.

I think it could be guessing from previous naming rules.

SAMSUNG_DA_WASHER_DRYER_HUB
SAMSUNG_DA_COOKTOP_HUB

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @nathankooistra Can you please help to define above hardware types?

SAMSUNG_DA_WASHER_DRYER_HUB
SAMSUNG_DA_COOKTOP_HUB

Regarding badge icons(badge icon url), it is undergoing below ticket.
https://smartthings.atlassian.net/browse/CAPI-6509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants