Add additional Aqara Light Switch H2 models #1915
Conversation
- 2 Buttons, 1 Channel (PID=0x1003) - 2 Buttons, 2 Channels (PID=0x1004) - 4 Buttons, 3 Channels (PID=0x1005)
|
Invitation URL: |
Test Results 64 files 409 suites 0s ⏱️ Results for commit 1df18d0. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1df18d0 |
There was a problem hiding this comment.
Hey @DongHoon-Ryu I believe in order to make this PR functional, you would need to add fingerprints for these devices as well. I reviewed the fingerprints available in the MAIN branch of our repo and do not see fingerprints for these devices.
Could you please add them as well?
Also please reach out via slack as well to share the testing plans for these changes thank you kindly.
| { vendor_id = 0x115F, product_id = 0x1003, target_profile = "light-power-energy-powerConsumption" }, -- 2 Buttons, 1 Channel | ||
| { vendor_id = 0x115F, product_id = 0x1004, target_profile = "light-power-energy-powerConsumption" }, -- 2 Buttons, 2 Channels | ||
| { vendor_id = 0x115F, product_id = 0x1005, target_profile = "light-power-energy-powerConsumption" }, -- 4 Buttons, 3 Channels | ||
| { vendor_id = 0x115F, product_id = 0x1008, target_profile = "light-power-energy-powerConsumption" }, -- 2 Buttons, 1 Channel |
There was a problem hiding this comment.
Are pids 1003 and 1008 both "2 Button, 1 Channel" devices?
There was a problem hiding this comment.
Yes, that's right. According to CSA's Certification, PID 0x1003 is for the US market and PID 0x1008 is for the EU market.
Hey @lelandblue |
Check all that apply
Type of Change
Checklist
Description of Change
Add additional Aqara Light Switch H2 models
Summary of Completed Tests
Check normal operation through test for existing model