-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include support for a bad wind support mode mapping #1916
Open
hcarter-775
wants to merge
4
commits into
main
Choose a base branch
from
fix/support-bad-wind-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Invitation URL: |
Minimum allowed coverage is Generated by 🐒 cobertura-action against fb42613 |
These changes look pretty straightforward. I was trying to trace through the logic for the following sequence, does this look right to you? I think this matches scenario (2) you provided in the PR description
|
07e556c
to
fb42613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are some devices that claim to support the Wind feature, but whose WindSupport attribute is empty. This update will force a read of that attribute before profiling can occur in the case that the Wind feature is supported to ensure that at least one value is specified. If no value is specified, wind support is not included in the resulting profile.
There are a few paths this logic can follow, so here is the reasoning for each path:
do_configure
runs first -> checks if battery is supportedbattery is supported
-> we read the PowerSource AttributeList.a. In
attribute_list_handler
->match_profile
runs with the specified battery typeb. In
match_profile
-> if the wind feature is not supported, a profile is chosen.c. Else -> the battery type specified is saved. we read FanControl WindSupport.
match_profile
returns earlywind_support_handler
-> we count the supported modes. a capability event is emitted.match_profile
runs again.match_profile
-> a profile is chosen.battery is not supported
->match_profile
runs directly fromdo_configure
.a. See
b. c. i. and ii.
above for the following logic.Re-formation of the previous PR 1577
Summary of Completed Tests