Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hue): Fix Mirek -> Kelvin conversion constant. #1934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dljsjr
Copy link
Contributor

@dljsjr dljsjr commented Feb 13, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This constant should be 100, but I resolved a conflict during a rebase incorrectly when prepping the original PR and it got set to 11 instead of 100.

Summary of Completed Tests

  • Tested on real devices
  • New Busted tests added to verify behavior at the min/max boundaries.

Copy link

Copy link

github-actions bot commented Feb 13, 2025

Test Results

   64 files    409 suites   0s ⏱️
2 033 tests 2 033 ✅ 0 💤 0 ❌
3 512 runs  3 512 ✅ 0 💤 0 ❌

Results for commit cf090e5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 13, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against cf090e5

This constant should be 100, but I resolved a conflict during a rebase incorrectly
when prepping the original PR and it got set to 11 instead of 100.
@dljsjr dljsjr force-pushed the fix/hue-incorrect-kelvin-step-size branch from 1368feb to cf090e5 Compare February 13, 2025 20:59
@dljsjr dljsjr requested a review from greens February 13, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants