Matter Switch: Support Fan/Light device #2032
Merged
+479
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 66 files 422 suites 0s ⏱️ Results for commit aa7c504. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against aa7c504 |
This change adds a new profile for a fan+color light device, brings in handlers for fan attributes and capabilities, and adds new logic to select the new profile and create the component map.
nickolas-deboom
force-pushed
the
matter-switch-support-fan-light
branch
from
8b8df76 to
feeaad8
Compare
|
Can you do an onboarding test of a light-button device as well? Also, one with a multi-button device? Just trying to hit all the affected paths. We should also test a parent-child switch device since the handling for their creation was moved. |
hcarter-775
reviewed
Apr 9, 2025
hcarter-775
reviewed
Apr 9, 2025
hcarter-775
reviewed
Apr 9, 2025
ctowns
reviewed
Apr 9, 2025
ctowns
reviewed
Apr 9, 2025
Remove endpoint checks in initialize_switch and adjust called functions accordingly.
nickolas-deboom
force-pushed
the
matter-switch-support-fan-light
branch
from
ef9c633 to
cc34662
Compare
|
Duplicate profile check: Passed - no duplicate profiles detected. |
hcarter-775
reviewed
Apr 10, 2025
hcarter-775
reviewed
Apr 10, 2025
This commit changes the fan/light configuration to be a single component rather than MCD, for reasons layed out in the review discussion.
nickolas-deboom
force-pushed
the
matter-switch-support-fan-light
branch
from
d4cd82c to
57d4ccd
Compare
hcarter-775
reviewed
Apr 10, 2025
build_component_map functions specific to buttons
hcarter-775
reviewed
Apr 10, 2025
nickolas-deboom
force-pushed
the
matter-switch-support-fan-light
branch
from
ea30c7e to
0672e79
Compare
12 tasks
hcarter-775
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This change adds driver support for a new profile for a fan+color light device added by a previous PR, brings in handlers for fan attributes and capabilities, and adds new logic to select the new profile and create the component map.
Summary of Completed Tests
Tested with: Orein fan+light and regression tested with Inovelli dimmer switch, Ikea 7 button remote, and VDA water valve device.