Skip to content

Commit

Permalink
v1.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
attipaci committed Aug 3, 2024
1 parent df7c5d1 commit cec058f
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 13 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ which affected prior SuperNOVAS releases.
independently of the (optional) gravitational corrections.

- #51: In the NOVAS C 3.1 implementation of `rad_vel()`, the Solar gravitational potential was ignored when
calculating radial velocities. Typically 'observing the Sun' means looking at its photosphere. As the light travels
away from the Sun's photosphere towards the observer, it is redshifted. The NOVAS C implementation of `rad_vel()`
has ignored this redshifting when the Sun was being observed. From now on, we shall gravitationally reference radial
velocities when observing the Sun to its photosphere .
calculating radial velocities for the Sun. Typically 'observing the Sun' means looking at its photosphere. As the
light travels away from the Sun's photosphere towards the observer, it is redshifted. The NOVAS C implementation of
`rad_vel()` has ignored this redshifting when the Sun was being observed. From now on, we shall gravitationally
reference radial velocities when observing the Sun to its photosphere.

- #34: `place()` radial velocities were not quite correct in NOVAS C 3.1, and in prior SuperNOVAS releases. The
radial velocity calculation now precedes aberration, since the radial velocity that is observed is in the geometric
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ provided by SuperNOVAS over the upstream NOVAS C 3.1 code:
independently of the (optional) gravitational corrections.

- [__v1.1__] In the NOVAS C 3.1 implementation of `rad_vel()`, the Solar gravitational potential was ignored when
calculating radial velocities. Typically 'observing the Sun' means looking at its photosphere, As the light travels
away from the Sun's photosphere towards the observer, it is redshifted. The NOVAS C implementation of `rad_vel()`
has ignored this redshifting when the Sun was being observed.
calculating radial velocities for the Sun. Typically 'observing the Sun' means looking at its photosphere, As the
light travels away from the Sun's photosphere towards the observer, it is redshifted. The NOVAS C implementation of
`rad_vel()` has ignored this redshifting when the Sun was being observed.

- [__v1.1__] `place()` radial velocities were not quite correct in NOVAS C 3.1, and in prior SuperNOVAS releases. The
radial velocity calculation now precedes aberration, since the radial velocity that is observed is in the geometric
Expand Down
8 changes: 5 additions & 3 deletions include/novas.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
#define SUPERNOVAS_PATCHLEVEL 0

/// Additional release information in version, e.g. "-1", or "-rc1".
#define SUPERNOVAS_RELEASE_STRING "-devel"
#define SUPERNOVAS_RELEASE_STRING ""



Expand Down Expand Up @@ -141,6 +141,10 @@
/// meters^3 / second^2, from DE-405.
#define NOVAS_G_EARTH 3.98600433e+14

/// [m] Solar radius (photosphere)
/// @since 1.1
#define NOVAS_SOLAR_RADIUS 696340000.0

/// [m] Radius of Earth in meters from IERS Conventions (2003).
#define NOVAS_EARTH_RADIUS 6378136.6

Expand All @@ -158,8 +162,6 @@
/// [s] TT - TAI time offset
#define NOVAS_TAI_TO_TT 32.187

/// [m] Solar radius
#define NOVAS_SOLAR_RADIUS 696340000.0

/// Reciprocal masses of solar system bodies, from DE-405 (Sun mass / body mass).
/// [0]: Earth/Moon barycenter, MASS[1] = Mercury, ...,
Expand Down
6 changes: 3 additions & 3 deletions src/novas.c
Original file line number Diff line number Diff line change
Expand Up @@ -4362,7 +4362,7 @@ int grav_planets(const double *pos_src, const double *pos_obs, const novas_plane
tsrc = novas_vlen(pos_src) / C_AUDAY;

for(i = 1; i < NOVAS_PLANETS; i++) {
double lt, dlt, dpl, p1[3];
double lt, dpl, p1[3];
int k;

if((planets->mask & (1 << i)) == 0)
Expand All @@ -4389,11 +4389,11 @@ int grav_planets(const double *pos_src, const double *pos_obs, const novas_plane
lt = tsrc;

// Differential light time w.r.t. the apparent planet center
dlt = (lt - dpl / C_AUDAY);
lt -= dpl / C_AUDAY;

// Calculate planet position at the time it is gravitationally acting on light.
for(k = 3; --k >= 0;)
p1[k] = pos_obs[k] + planets->pos[i][k] - dlt * planets->vel[i][k];
p1[k] = pos_obs[k] + planets->pos[i][k] - lt * planets->vel[i][k];

// Compute deflection due to gravitating body.
grav_vec(out, pos_obs, p1, rmass[i], out);
Expand Down

0 comments on commit cec058f

Please sign in to comment.