-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attipaci
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jan 31, 2024
…hstanding known issues in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial SuperNOVAS implementation:
Bugs fixed:
sidereal_time
bugephem_close
bugephemeris()
ira_equinox()
which may return the result for the wrong type of equinox if the the 'equinox' argument was changing from 1 to 0, and back to 1 again with the date being the same.cio_basis()
,cio_location()
,ecl2equ_vec()
,equ2ecl_vec()
,geo_posvel()
,place()
, andsidereal_time()
, which could return a cached value for the other accuracy if the other input parameters are the same as a prior call with different accuracy.cio_basis()
with alternating CIO location reference systems.equ2ecl_vec()
andecl2equ_vec()
whereby a query withcoord_sys = 2
(GCRS) has overwritten thecached mean obliquity value for
coord_sys = 0
(mean equinox of date). As a result, a subsequent call withcoord_sys = 0
and the same date as before would return the results GCRS coordinates instead of therequested mean equinox of date coordinates.
fmod()
insolsys3.c
, leading to incorrect calculation of the mean anomaly for date prior to J2000, hence incorrect positions for Sun and Earth.Additions:
solarsystem()
and ephemeris_reader implementations.Changes:
const
modifiers for non-output pointer arguments