Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further CSPICE support, improved error handling #89

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Nov 11, 2024

  • Improved error handling, printing CSPICE short error messages when debug mode is enabled.
  • Added convenience functions to manage active kernels:
    • cspice_add_kernel() -- wraps the CSPICE furnsh_c() function with graceful error handling.
    • cspice_remove_kernel() -- wraps the CSPICE unload_c() function with graceful error handling.

@attipaci attipaci added the enhancement New feature or request label Nov 11, 2024
@attipaci attipaci added this to the 1.2.0 milestone Nov 11, 2024
@attipaci attipaci self-assigned this Nov 11, 2024
@attipaci attipaci linked an issue Nov 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (51fadb0) to head (bda1586).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           8        8           
  Lines        2904     2904           
  Branches      561      561           
=======================================
  Hits         2894     2894           
  Partials       10       10           
Flag Coverage Δ
unittests 99.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fadb0...bda1586. Read the comment docs.

@attipaci attipaci force-pushed the further-cspice-support branch 2 times, most recently from f6d13e2 to ef700ff Compare November 11, 2024 09:52
@attipaci attipaci marked this pull request as ready for review November 11, 2024 09:55
@attipaci attipaci merged commit 0e7ef7c into main Nov 11, 2024
16 checks passed
@attipaci attipaci deleted the further-cspice-support branch November 11, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for NAIF CSPICE
1 participant