Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support movable orbit pivot point #3

Closed
wants to merge 2 commits into from

Conversation

sdumetz
Copy link

@sdumetz sdumetz commented Apr 30, 2024

Required to merge Smithsonian/dpo-voyager#266

@sdumetz
Copy link
Author

sdumetz commented May 2, 2024

I updated zoomExtents to follow the pivot point. I don't like it, it often feels wrong when used on exotic view points but it's not worse than it was and that's a hard problem to solve —one with no "universal best" solution— better left for a future update IMO.

sdumetz added a commit to Holusion/dpo-voyager that referenced this pull request Aug 1, 2024
sdumetz added a commit to Holusion/dpo-voyager that referenced this pull request Aug 1, 2024
@sdumetz
Copy link
Author

sdumetz commented Aug 1, 2024

No longer necessary since submodules have been dropped from DPO-Voyager

@sdumetz sdumetz closed this Aug 1, 2024
sdumetz added a commit to Holusion/dpo-voyager that referenced this pull request Sep 3, 2024
sdumetz added a commit to Holusion/dpo-voyager that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant