Skip to content

randomfileadded#82

Closed
eshant742 wants to merge 1 commit intoSmoren:masterfrom
eshant742:randomrps
Closed

randomfileadded#82
eshant742 wants to merge 1 commit intoSmoren:masterfrom
eshant742:randomrps

Conversation

@eshant742
Copy link

random.ts file added in src which implements the required functions

@Smoren
Copy link
Owner

Smoren commented Feb 13, 2025

Hi @eshant742! Thank you for your PR!

There are a few things that need to be fixed and completed before I can merge it.

  1. You have created objects Stream and AsyncStream in the file random.ts with method rockPaperScissors. Instead, you have to add these methods to the existing Stream and AsyncStream classes (see files stream.ts, async-stream.ts).

  2. Please export the new functions (rockPaperScissors and rockPaperScissorsAsync) in the file index.ts.

  3. The new functions and methods need to be covered by tests, similar to how the previously implemented functions and methods are tested.

If you have any questions, feel free to reach out.

@Smoren
Copy link
Owner

Smoren commented Sep 6, 2025

Hi @eshant742
Do you plan to continue working on this PR?

@Smoren Smoren closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants