Dev reels dl fix #200
Open
Dev reels dl fix #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SoCuul
force-pushed
the
fix/reelsDownload
branch
from
e6e326a to
30fd92f
Compare
Owner
|
If you could test my commit and make sure it works, that'd be great. Thanks for this :D |
jithatsonei
force-pushed
the
fix/reelsDownload
branch
from
d0bdfdf to
392de7c
Compare
Author
|
@SoCuul ok hopefully you didnt see me merge dev into here lmao, but unscrewed that piece wasnt building at first so just cleaned up the function which made it build, tested both on 398 and 396 and photos/videos/reels are downloading! also if meta trolls us enough with these repeated changes to their props within the reels/videos classes - may be best to do a switch case instead of nesting down ifs |
jithatsonei
force-pushed
the
fix/reelsDownload
branch
from
466e0f7 to
cf178cb
Compare
Author
|
rebased to latest dev commit |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty nasty but it works, feel free to improve!
Fixes #199