replace getStdOut() with OS write syscalls#337
Open
legenduzo wants to merge 2 commits intoSobeston:masterfrom
Open
replace getStdOut() with OS write syscalls#337legenduzo wants to merge 2 commits intoSobeston:masterfrom
legenduzo wants to merge 2 commits intoSobeston:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sobeston,
I just made an update to transition the deprecated
getStdOutfunction from its dependence on io to using Zig's wrapper around the syscalls.I've tested the code locally and it compiles, and I've gone through "CONTRIBUTING" on readme.md, but I did not find the test folder in the codebase to see how to improve that.
Please let me know if there's something you'd like me to improve.