Skip to content

add/set approvedScopes in User#206

Closed
lsnider wants to merge 3 commits into
SocialiteProviders:masterfrom
gozowy:track-approved-scopes
Closed

add/set approvedScopes in User#206
lsnider wants to merge 3 commits into
SocialiteProviders:masterfrom
gozowy:track-approved-scopes

Conversation

@lsnider

@lsnider lsnider commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

If laravel/socialite#572 gets merged, this PR brings the approved scopes to SocialiteProviders.

@lsnider

lsnider commented Jan 27, 2022

Copy link
Copy Markdown
Contributor Author

Now that the laravel/socialite#572 PR has been merged, this can too but we may need to address that this package supports "laravel/socialite": "~4.0 || ~5.0" where as laravel/socialite#572 was merged into the 5.x branch. Perhaps now is a good time to drop support for 4.x?

@stale

stale Bot commented Apr 9, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 9, 2022
@stale stale Bot closed this Apr 16, 2022
@lsnider

lsnider commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

Poke

@satezmedia

satezmedia commented Mar 29, 2023

Copy link
Copy Markdown

@atymic Would it be possible to reopen/merge this PR?

@bilfeldt

bilfeldt commented Apr 5, 2024

Copy link
Copy Markdown

Let us re-open this issue 👍 It is a better solution than the currently open (draft) PR #225 and is closes #224

Things that need to be addressed:

@atymic atymic reopened this Apr 29, 2024
@stale stale Bot removed the stale label Apr 29, 2024
@atymic

atymic commented Apr 29, 2024

Copy link
Copy Markdown
Member

@bilfeldt Re-opened.

Maybe we should override the default method, see comment.

Comment thread src/OAuth2/AbstractProvider.php
@codecov

codecov Bot commented Apr 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (82c9bda) to head (6dd81fc).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
- Coverage     53.94%   53.94%   -0.01%     
- Complexity       77       79       +2     
============================================
  Files            10       10              
  Lines           228      241      +13     
============================================
+ Hits            123      130       +7     
- Misses          105      111       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants