fix(DATAGO-133564): Fix 'Stop' button cutoff in narrow chat window#1455
fix(DATAGO-133564): Fix 'Stop' button cutoff in narrow chat window#1455amir-ghasemi merged 6 commits intomainfrom
Conversation
amir-ghasemi
changed the title
✅ FOSSA Guard: Licensing (
|
✅ FOSSA Guard: Vulnerability (
|
amir-ghasemi
changed the title
amir-ghasemi
changed the title
| </Button> | ||
|
|
||
| <div>Agent: </div> | ||
| <div className="hidden @[480px]:block">Agent: </div> |
There was a problem hiding this comment.
Can we extract this hidden @[480px]:block and hidden @[480px]:inline to sharable constants?
| borderRadius: "2px", | ||
| backgroundColor: isChecked ? "var(--primary-wMain)" : "transparent", | ||
| backgroundImage: isChecked | ||
| ? "url(\"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 16 16' fill='white'%3E%3Cpath d='M13.78 4.22a.75.75 0 0 1 0 1.06l-7 7a.75.75 0 0 1-1.06 0l-3-3a.75.75 0 1 1 1.06-1.06L6.25 10.69l6.47-6.47a.75.75 0 0 1 1.06 0Z'/%3E%3C/svg%3E\")" |
There was a problem hiding this comment.
There's a "white" in here - does it look ok in both themes?
But, this does seem kind of fragile and there are some more standard ways? Could use lucide icons? Or could just style the input (add a domNode.attribs.class = "size-3.5..." or something)? There's also a checkbox component, but that might be heavy for this usage
Could you explore the second suggestion? Accepting the input and just rendering it slightly differently?
|
2 participants
Also addresses: DATAGO-133557
Fix broken icons in the Plan section
This pull request improves the display and handling of GitHub-flavored Markdown (GFM) task lists in the chat UI, enhances responsive design for chat controls, and updates agent templates to encourage proper Markdown checklist syntax. The most significant changes are grouped below:
Markdown Task List Rendering:
MarkdownHTMLConvertercomponent now detects and renders GFM task list checkboxes with custom-styled spans instead of native inputs, ensuring correct appearance and accessibility. List and list item styling is also adjusted to visually match GitHub's task lists. [1] [2]Agent and Template Instructions:
- [ ],- [x]) for checklists, and to avoid using emoji squares or other symbols. This ensures consistent rendering in the frontend. [1] [2] [3]Responsive and Accessibility Improvements: